From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 04/18] ehci: move ehci_flush_qh
Date: Fri, 25 May 2012 14:40:20 +0200 [thread overview]
Message-ID: <1337949634-5264-6-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1337949634-5264-1-git-send-email-kraxel@redhat.com>
Move ehci_flush_qh() function up in the source code.
No code change.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-ehci.c | 35 ++++++++++++++++++-----------------
1 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index d7131bd..f21b4be 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -1553,6 +1553,24 @@ static int ehci_process_itd(EHCIState *ehci,
return 0;
}
+
+/*
+ * Write the qh back to guest physical memory. This step isn't
+ * in the EHCI spec but we need to do it since we don't share
+ * physical memory with our guest VM.
+ *
+ * The first three dwords are read-only for the EHCI, so skip them
+ * when writing back the qh.
+ */
+static void ehci_flush_qh(EHCIQueue *q)
+{
+ uint32_t *qh = (uint32_t *) &q->qh;
+ uint32_t dwords = sizeof(EHCIqh) >> 2;
+ uint32_t addr = NLPTR_GET(q->qhaddr);
+
+ put_dwords(q->ehci, addr + 3 * sizeof(uint32_t), qh + 3, dwords - 3);
+}
+
/* This state is the entry point for asynchronous schedule
* processing. Entry here consitutes a EHCI start event state (4.8.5)
*/
@@ -1869,23 +1887,6 @@ static int ehci_state_horizqh(EHCIQueue *q, int async)
return again;
}
-/*
- * Write the qh back to guest physical memory. This step isn't
- * in the EHCI spec but we need to do it since we don't share
- * physical memory with our guest VM.
- *
- * The first three dwords are read-only for the EHCI, so skip them
- * when writing back the qh.
- */
-static void ehci_flush_qh(EHCIQueue *q)
-{
- uint32_t *qh = (uint32_t *) &q->qh;
- uint32_t dwords = sizeof(EHCIqh) >> 2;
- uint32_t addr = NLPTR_GET(q->qhaddr);
-
- put_dwords(q->ehci, addr + 3 * sizeof(uint32_t), qh + 3, dwords - 3);
-}
-
static int ehci_state_execute(EHCIQueue *q, int async)
{
EHCIPacket *p = QTAILQ_FIRST(&q->packets);
--
1.7.1
next prev parent reply other threads:[~2012-05-25 12:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 12:40 [Qemu-devel] [PATCH 00/18] ehci updates Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 01/18] ehci: add EHCIPacket Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH] uhci: fix irq routing Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 02/18] ehci: make ehci_execute work on EHCIPacket instead of EHCIQueue Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 03/18] ehci: cache USBDevice in EHCIQueue Gerd Hoffmann
2012-05-25 12:40 ` Gerd Hoffmann [this message]
2012-05-25 12:40 ` [Qemu-devel] [PATCH 05/18] ehci: add queuing support Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 06/18] ehci: tweak queue initialization Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 07/18] ehci: add async field to EHCIQueue Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 08/18] ehci: move async schedule to bottom half Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 09/18] ehci: schedule async bh on async packet completion Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 10/18] ehci: kick async schedule on wakeup Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 11/18] ehci: fix reset Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 12/18] ehci: add ehci_*_enabled() helpers Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 13/18] ehci: update status bits in ehci_set_state Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 14/18] ehci: fix halt status handling Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 15/18] ehci: remove unused attach_poll_counter Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 16/18] ehci: create ehci_update_frindex Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 17/18] ehci: adaptive wakeup rate Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 18/18] ehci: rework frame skipping Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337949634-5264-6-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).