From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 06/18] ehci: tweak queue initialization
Date: Fri, 25 May 2012 14:40:22 +0200 [thread overview]
Message-ID: <1337949634-5264-8-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1337949634-5264-1-git-send-email-kraxel@redhat.com>
Little tweak for the queue initialization, set the QH address in the
allocation function.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-ehci.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index ccaa947..aa67af6 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -692,13 +692,14 @@ static void ehci_free_packet(EHCIPacket *p)
/* queue management */
-static EHCIQueue *ehci_alloc_queue(EHCIState *ehci, int async)
+static EHCIQueue *ehci_alloc_queue(EHCIState *ehci, uint32_t addr, int async)
{
EHCIQueueHead *head = async ? &ehci->aqueues : &ehci->pqueues;
EHCIQueue *q;
q = g_malloc0(sizeof(*q));
q->ehci = ehci;
+ q->qhaddr = addr;
QTAILQ_INIT(&q->packets);
QTAILQ_INSERT_HEAD(head, q, next);
trace_usb_ehci_queue_action(q, "alloc");
@@ -1672,12 +1673,11 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci, int async)
entry = ehci_get_fetch_addr(ehci, async);
q = ehci_find_queue_by_qh(ehci, entry, async);
if (NULL == q) {
- q = ehci_alloc_queue(ehci, async);
+ q = ehci_alloc_queue(ehci, entry, async);
}
p = QTAILQ_FIRST(&q->packets);
- q->qhaddr = entry;
- q->seen++;
+ q->seen++;
if (q->seen > 1) {
/* we are going in circles -- stop processing */
ehci_set_state(ehci, async, EST_ACTIVE);
--
1.7.1
next prev parent reply other threads:[~2012-05-25 12:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 12:40 [Qemu-devel] [PATCH 00/18] ehci updates Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 01/18] ehci: add EHCIPacket Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH] uhci: fix irq routing Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 02/18] ehci: make ehci_execute work on EHCIPacket instead of EHCIQueue Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 03/18] ehci: cache USBDevice in EHCIQueue Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 04/18] ehci: move ehci_flush_qh Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 05/18] ehci: add queuing support Gerd Hoffmann
2012-05-25 12:40 ` Gerd Hoffmann [this message]
2012-05-25 12:40 ` [Qemu-devel] [PATCH 07/18] ehci: add async field to EHCIQueue Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 08/18] ehci: move async schedule to bottom half Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 09/18] ehci: schedule async bh on async packet completion Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 10/18] ehci: kick async schedule on wakeup Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 11/18] ehci: fix reset Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 12/18] ehci: add ehci_*_enabled() helpers Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 13/18] ehci: update status bits in ehci_set_state Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 14/18] ehci: fix halt status handling Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 15/18] ehci: remove unused attach_poll_counter Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 16/18] ehci: create ehci_update_frindex Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 17/18] ehci: adaptive wakeup rate Gerd Hoffmann
2012-05-25 12:40 ` [Qemu-devel] [PATCH 18/18] ehci: rework frame skipping Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337949634-5264-8-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).