qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 01/10] qcow2: don't leak buffer for unexpected qcow_version in header
Date: Fri, 25 May 2012 19:38:45 +0200	[thread overview]
Message-ID: <1337967534-12166-2-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1337967534-12166-1-git-send-email-kwolf@redhat.com>

From: Jim Meyering <jim@meyering.net>

Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 655799c..c2e49cd 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -919,7 +919,8 @@ int qcow2_update_header(BlockDriverState *bs)
         ret = sizeof(*header);
         break;
     default:
-        return -EINVAL;
+        ret = -EINVAL;
+        goto fail;
     }
 
     buf += ret;
-- 
1.7.6.5

  reply	other threads:[~2012-05-25 17:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 17:38 [Qemu-devel] [PULL 00/10] Block patches for 1.1 Kevin Wolf
2012-05-25 17:38 ` Kevin Wolf [this message]
2012-05-25 17:38 ` [Qemu-devel] [PATCH 02/10] qemu-img: Explain how rebase operation can be used to perform a 'diff' operation Kevin Wolf
2012-05-25 17:38 ` [Qemu-devel] [PATCH 03/10] sheepdog: mark image as snapshot when tag is specified Kevin Wolf
2012-05-25 17:38 ` [Qemu-devel] [PATCH 04/10] sheepdog: return -errno on error Kevin Wolf
2012-05-25 17:38 ` [Qemu-devel] [PATCH 05/10] sheepdog: use heap instead of stack for BDRVSheepdogState Kevin Wolf
2012-05-25 17:38 ` [Qemu-devel] [PATCH 06/10] qcow2: Check qcow2_alloc_clusters_at() return value Kevin Wolf
2012-05-25 17:38 ` [Qemu-devel] [PATCH 07/10] qemu-iotests: mark 035 qcow2-only Kevin Wolf
2012-05-25 17:38 ` [Qemu-devel] [PATCH 08/10] fdc: floppy drive should be visible after start without media Kevin Wolf
2012-05-25 17:38 ` [Qemu-devel] [PATCH 09/10] fdc: fix media detection Kevin Wolf
2012-05-25 17:38 ` [Qemu-devel] [PATCH 10/10] fdc-test: introduced qtest no_media_on_start and cmos qtest for floppy Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337967534-12166-2-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).