From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXyTf-0006Zc-Re for qemu-devel@nongnu.org; Fri, 25 May 2012 13:39:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXyTc-0000Ci-T7 for qemu-devel@nongnu.org; Fri, 25 May 2012 13:39:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXyTc-0000CM-Kg for qemu-devel@nongnu.org; Fri, 25 May 2012 13:39:00 -0400 From: Kevin Wolf Date: Fri, 25 May 2012 19:38:45 +0200 Message-Id: <1337967534-12166-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1337967534-12166-1-git-send-email-kwolf@redhat.com> References: <1337967534-12166-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 01/10] qcow2: don't leak buffer for unexpected qcow_version in header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Jim Meyering Signed-off-by: Jim Meyering Signed-off-by: Kevin Wolf --- block/qcow2.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 655799c..c2e49cd 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -919,7 +919,8 @@ int qcow2_update_header(BlockDriverState *bs) ret = sizeof(*header); break; default: - return -EINVAL; + ret = -EINVAL; + goto fail; } buf += ret; -- 1.7.6.5