From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, alevy@redhat.com, armbru@redhat.com
Subject: [Qemu-devel] [PATCH 03/14] cutils: introduce qemu_fopen_err()
Date: Fri, 25 May 2012 16:41:08 -0300 [thread overview]
Message-ID: <1337974879-3656-4-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1337974879-3656-1-git-send-email-lcapitulino@redhat.com>
A fopen() wrapper that takes an Error argument.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
cutils.c | 42 ++++++++++++++++++++++++++++++++++++++++++
qemu-common.h | 3 +++
2 files changed, 45 insertions(+)
diff --git a/cutils.c b/cutils.c
index af308cd..bdee130 100644
--- a/cutils.c
+++ b/cutils.c
@@ -26,6 +26,7 @@
#include <math.h>
#include "qemu_socket.h"
+#include "error.h"
void pstrcpy(char *buf, int buf_size, const char *str)
{
@@ -549,3 +550,44 @@ int qemu_sendv(int sockfd, struct iovec *iov, int len, int iov_offset)
return do_sendv_recvv(sockfd, iov, len, iov_offset, 1);
}
+static void set_open_err(Error **errp, const char *path, int err_nr)
+{
+ switch (err_nr) {
+ case EACCES:
+ error_set(errp, QERR_INVALID_ACCESS);
+ return;
+ case EMFILE:
+ error_set(errp, QERR_TOO_MANY_FILES_PROC);
+ return;
+ case ENFILE:
+ error_set(errp, QERR_TOO_MANY_FILES_SYS);
+ return;
+ case ENAMETOOLONG:
+ error_set(errp, QERR_NAME_TOO_LONG);
+ return;
+ case ENOSPC:
+ error_set(errp, QERR_NO_SPACE);
+ return;
+ case EPERM:
+ error_set(errp, QERR_PERMISSION_DENIED);
+ return;
+ case EROFS:
+ error_set(errp, QERR_READ_ONLY_FS);
+ return;
+ default:
+ error_set(errp, QERR_OPEN_FILE_FAILED, path);
+ return;
+ }
+}
+
+FILE *qemu_fopen_err(const char *path, const char *mode, Error **errp)
+{
+ FILE *fp;
+
+ fp = fopen(path, mode);
+ if (!fp) {
+ set_open_err(errp, path, errno);
+ }
+
+ return fp;
+}
diff --git a/qemu-common.h b/qemu-common.h
index cccfb42..2cab2a8 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -4,6 +4,7 @@
#include "compiler.h"
#include "config-host.h"
+#include "error.h"
#if defined(__arm__) || defined(__sparc__) || defined(__mips__) || defined(__hppa__) || defined(__ia64__)
#define WORDS_ALIGNED
@@ -208,6 +209,8 @@ int qemu_pipe(int pipefd[2]);
int qemu_recvv(int sockfd, struct iovec *iov, int len, int iov_offset);
int qemu_sendv(int sockfd, struct iovec *iov, int len, int iov_offset);
+FILE *qemu_fopen_err(const char *path, const char *mode, Error **errp);
+
/* Error handling. */
void QEMU_NORETURN hw_error(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
--
1.7.10.2.565.gbd578b5
next prev parent reply other threads:[~2012-05-25 19:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 19:41 [Qemu-devel] [PATCH qmp-next 00/14]: qapi: convert screendump Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 01/14] qerror: extend QERR_TOO_MANY_FILES Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 02/14] qerror: add new errors Luiz Capitulino
2012-05-25 19:41 ` Luiz Capitulino [this message]
2012-05-25 19:41 ` [Qemu-devel] [PATCH 04/14] cutils: introduce qemu_fprintf_err() Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 05/14] cutils: introduce qemu_fputc_err() Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 06/14] cutils: introduce qemu_fwrite_err() Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 07/14] omap_lcdc: rename ppm_save() to omap_ppm_save() Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 08/14] console: vga_hw_screen_dump_ptr: take an Error argument Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 09/14] vga: ppm_save(): add error handling Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 10/14] omap_lcdc: omap_ppm_save(): " Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 11/14] g364fb: g364fb_screen_dump(): " Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 12/14] tcx: tcx24_screen_dump(): " Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 13/14] tcx: tcx_screen_dump(): " Luiz Capitulino
2012-05-25 19:41 ` [Qemu-devel] [PATCH 14/14] qapi: convert screendump Luiz Capitulino
2012-05-28 8:56 ` Alon Levy
2012-05-28 13:12 ` Luiz Capitulino
2012-05-28 8:57 ` [Qemu-devel] [PATCH qmp-next 00/14]: " Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337974879-3656-4-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=alevy@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).