From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urjyy-0003jZ-Fg for qemu-devel@nongnu.org; Wed, 26 Jun 2013 03:17:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Urjyx-0004xr-BE for qemu-devel@nongnu.org; Wed, 26 Jun 2013 03:17:36 -0400 Received: from zose-mta12.web4all.fr ([178.33.204.89]:40531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urjyx-0004xm-1r for qemu-devel@nongnu.org; Wed, 26 Jun 2013 03:17:35 -0400 Date: Wed, 26 Jun 2013 09:17:47 +0200 (CEST) From: jcd@tribudubois.net Message-ID: <133798986.267652.1372231067532.JavaMail.root@tribudubois.net> In-Reply-To: <51CA9407.1020104@redhat.com> References: <1372184516-32397-1-git-send-email-peter.maydell@linaro.org> <1372184516-32397-3-git-send-email-peter.maydell@linaro.org> <51C9E490.7090304@redhat.com> <51CA9086.80802@redhat.com> <458051555.267249.1372230485548.JavaMail.root@tribudubois.net> <51CA9407.1020104@redhat.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_267651_1875718078.1372231067531" Subject: Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Peter Crosthwaite , Anthony Liguori , qemu-devel@nongnu.org, Paul Brook , Andreas =?utf-8?Q?F=C3=A4rber?= ------=_Part_267651_1875718078.1372231067531 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Thanks for the info. Is this consolidated into some "developper documentation" somewhere (a wiki, ...)? JC ----- Mail original ----- > Il 26/06/2013 09:08, jcd@tribudubois.net ha scritto: > > For my own education, could you elaborate on the reason this is not a > > good change? > Quoting from http://article.gmane.org/gmane.comp.emulators.qemu/218078: > > The MemoryRegion name is free text that can be changed as desired and > > doesn't need to match the type name. > > > > The TYPE_* constant serves to keep consistency between usages of the > > string literal but does not prohibit changing its value. > > > > The VMStateDescription should thus not use the TYPE_* constant because > > it must not ever change for live migration. Renaming a type is a valid > > thing to do if there is no command line compatibility to keep (think > > board-level "xlnx.foo" -> "xlnx,foo"). > Paolo ------=_Part_267651_1875718078.1372231067531 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks for the info.

Is this consolidated into some "developper documentation"= somewhere (a wiki, ...)?

JC
Il 26/06/2013 09:08, jcd@tribudubois.net ha scritto:
> For my o= wn education, could you elaborate on the reason this is not a
> good = change?

Quoting from http://article.gmane.org/gmane.comp.= emulators.qemu/218078:

> The MemoryRegion name is free= text that can be changed as desired and
> doesn't need to match the = type name.
>
> The TYPE_* constant serves to keep consistency = between usages of the
> string literal but does not prohibit changing= its value.
>
> The VMStateDescription should thus not use the= TYPE_* constant because
> it must not ever change for live migration= . Renaming a type is a valid
> thing to do if there is no command lin= e compatibility to keep (think
> board-level "xlnx.foo" -> "xlnx,f= oo").

Paolo

<= /html> ------=_Part_267651_1875718078.1372231067531--