From: Amos Kong <akong@redhat.com>
To: aliguori@us.ibm.com, eblake@redhat.com, berrange@redhat.com,
lcapitulino@redhat.com, qemu-devel@nongnu.org
Cc: Amos Kong <akong@redhat.com>
Subject: [Qemu-devel] [PATCH v2 4/6] hmp: rename arguments
Date: Sat, 2 Jun 2012 06:54:26 +0800 [thread overview]
Message-ID: <1338591268-23962-5-git-send-email-akong@redhat.com> (raw)
In-Reply-To: <1338591268-23962-1-git-send-email-akong@redhat.com>
Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'
Signed-off-by: Amos Kong <akong@redhat.com>
---
hmp-commands.hx | 2 +-
monitor.c | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index af18156..18b8e31 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -502,7 +502,7 @@ ETEXI
{
.name = "sendkey",
- .args_type = "string:s,hold_time:i?",
+ .args_type = "keys:s,hold-time:i?",
.params = "keys [hold_ms]",
.help = "send keys to the VM (e.g. 'sendkey ctrl-alt-f1', default hold time=100 ms)",
.mhandler.cmd = do_sendkey,
diff --git a/monitor.c b/monitor.c
index ecfcaa4..536d9dd 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1382,9 +1382,9 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
char keyname_buf[16];
char *separator;
int keyname_len, keycode, i;
- const char *string = qdict_get_str(qdict, "string");
- int has_hold_time = qdict_haskey(qdict, "hold_time");
- int hold_time = qdict_get_try_int(qdict, "hold_time", -1);
+ const char *keys = qdict_get_str(qdict, "keys");
+ int has_hold_time = qdict_haskey(qdict, "hold-time");
+ int hold_time = qdict_get_try_int(qdict, "hold-time", -1);
if (nb_pending_keycodes > 0) {
qemu_del_timer(key_timer);
@@ -1394,10 +1394,10 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
hold_time = 100;
i = 0;
while (1) {
- separator = strchr(string, '-');
- keyname_len = separator ? separator - string : strlen(string);
+ separator = strchr(keys, '-');
+ keyname_len = separator ? separator - keys : strlen(keys);
if (keyname_len > 0) {
- pstrcpy(keyname_buf, sizeof(keyname_buf), string);
+ pstrcpy(keyname_buf, sizeof(keyname_buf), keys);
if (keyname_len > sizeof(keyname_buf) - 1) {
monitor_printf(mon, "invalid key: '%s...'\n", keyname_buf);
return;
@@ -1423,7 +1423,7 @@ static void do_sendkey(Monitor *mon, const QDict *qdict)
}
if (!separator)
break;
- string = separator + 1;
+ keys = separator + 1;
}
nb_pending_keycodes = i;
/* key down events */
--
1.7.1
next prev parent reply other threads:[~2012-06-01 22:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 22:54 [Qemu-devel] [PATCH v2 0/6] convert sendkey to qapi Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 1/6] qerror: add QERR_OVERFLOW Amos Kong
2012-06-04 5:27 ` Anthony Liguori
2012-06-05 14:29 ` [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16 Amos Kong
[not found] ` <4FD0326F.3010806@redhat.com>
[not found] ` <20120611140642.06be2ee8@doriath.home>
[not found] ` <4FD62827.4060900@us.ibm.com>
[not found] ` <20120611142546.66871522@doriath.home>
2012-06-14 10:20 ` Amos Kong
2012-06-15 7:46 ` Amos Kong
2012-06-15 7:57 ` Gerd Hoffmann
2012-06-15 13:35 ` Luiz Capitulino
2012-06-18 15:30 ` Amos Kong
2012-06-19 9:52 ` Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 2/6] fix doc of using raw values with sendkey Amos Kong
2012-06-06 18:16 ` Luiz Capitulino
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 3/6] rename keyname '<' to 'less' Amos Kong
2012-06-06 18:22 ` Luiz Capitulino
2012-06-06 23:12 ` Amos Kong
2012-06-01 22:54 ` Amos Kong [this message]
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum Amos Kong
2012-06-05 15:01 ` Amos Kong
2012-06-06 18:40 ` Luiz Capitulino
2012-06-07 0:26 ` Michael Roth
2012-06-07 2:52 ` Amos Kong
2012-06-11 17:00 ` Luiz Capitulino
2012-06-07 0:15 ` Michael Roth
2012-06-07 3:33 ` Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey Amos Kong
2012-06-04 17:09 ` Eric Blake
2012-06-05 14:55 ` Amos Kong
2012-06-05 15:05 ` Eric Blake
2012-06-06 7:13 ` Amos Kong
2012-06-06 11:58 ` Eric Blake
2012-06-07 4:51 ` Anthony Liguori
2012-06-07 13:08 ` Eric Blake
2012-06-01 23:03 ` [Qemu-devel] [PATCH v2 0/6] convert sendkey to qapi Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338591268-23962-5-git-send-email-akong@redhat.com \
--to=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).