[Qemu-devel] [PATCH 0/7] esp: add AMD PCscsi emulation

[Qemu-devel] [PATCH 0/7] esp: add AMD PCscsi emulation

[Hervé Poussineau]

This patchset adds a PCI connection to the 53c9x emulation already
present in QEMU.  The emulated card is the AMD PCscsi adapter,
and has been tested on multiple Microsoft operating systems.

Hervé Poussineau (7):
  esp: implement Disable selection command
  esp: implement Reset ATN command
  esp: support future change of chip_id
  esp: use hba_private field instead of a complex cast
  esp: split esp code into generic chip emulation and sysbus layer
  esp: use error_report()/hw_error() instead of stderr output
  esp: add AMD PCscsi emulation (PCI SCSI adapter)

 default-configs/i386-softmmu.mak |    1 +
 hw/esp.c                         |  536 ++++++++++++++++++++++++++++++++------
 hw/pci_ids.h                     |    1 +
 trace-events                     |   10 +
 4 files changed, 468 insertions(+), 80 deletions(-)

-- 
1.7.10

[Qemu-devel] [PATCH 1/7] esp: implement Disable selection command

[Hervé Poussineau]

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/esp.c     |    6 ++++++
 trace-events |    1 +
 2 files changed, 7 insertions(+)

diff --git a/hw/esp.c b/hw/esp.c
index 8d73e56..51b2d5f 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -117,6 +117,7 @@ struct ESPState {
 #define CMD_SELATN   0x42
 #define CMD_SELATNS  0x43
 #define CMD_ENSEL    0x44
+#define CMD_DISSEL   0x45
 
 #define STAT_DO 0x00
 #define STAT_DI 0x01
@@ -644,6 +645,11 @@ static void esp_mem_write(void *opaque, target_phys_addr_t addr,
             trace_esp_mem_writeb_cmd_ensel(val);
             s->rregs[ESP_RINTR] = 0;
             break;
+        case CMD_DISSEL:
+            trace_esp_mem_writeb_cmd_dissel(val);
+            s->rregs[ESP_RINTR] = 0;
+            esp_raise_irq(s);
+            break;
         default:
             ESP_ERROR("Unhandled ESP command (%2.2x)\n", (unsigned)val);
             break;
diff --git a/trace-events b/trace-events
index 45c6bc1..898313c 100644
--- a/trace-events
+++ b/trace-events
@@ -637,6 +637,7 @@ esp_mem_writeb_cmd_sel(uint32_t val) "Select without ATN (%2.2x)"
 esp_mem_writeb_cmd_selatn(uint32_t val) "Select with ATN (%2.2x)"
 esp_mem_writeb_cmd_selatns(uint32_t val) "Select with ATN & stop (%2.2x)"
 esp_mem_writeb_cmd_ensel(uint32_t val) "Enable selection (%2.2x)"
+esp_mem_writeb_cmd_dissel(uint32_t val) "Disable selection (%2.2x)"
 
 # monitor.c
 handle_qmp_command(void *mon, const char *cmd_name) "mon %p cmd_name \"%s\""
-- 
1.7.10

[Qemu-devel] [PATCH 2/7] esp: implement Reset ATN command

[Hervé Poussineau]

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/esp.c     |    4 ++++
 trace-events |    1 +
 2 files changed, 5 insertions(+)

diff --git a/hw/esp.c b/hw/esp.c
index 51b2d5f..e726e11 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -113,6 +113,7 @@ struct ESPState {
 #define CMD_MSGACC   0x12
 #define CMD_PAD      0x18
 #define CMD_SATN     0x1a
+#define CMD_RSTATN   0x1b
 #define CMD_SEL      0x41
 #define CMD_SELATN   0x42
 #define CMD_SELATNS  0x43
@@ -629,6 +630,9 @@ static void esp_mem_write(void *opaque, target_phys_addr_t addr,
         case CMD_SATN:
             trace_esp_mem_writeb_cmd_satn(val);
             break;
+        case CMD_RSTATN:
+            trace_esp_mem_writeb_cmd_rstatn(val);
+            break;
         case CMD_SEL:
             trace_esp_mem_writeb_cmd_sel(val);
             handle_s_without_atn(s);
diff --git a/trace-events b/trace-events
index 898313c..81780f0 100644
--- a/trace-events
+++ b/trace-events
@@ -633,6 +633,7 @@ esp_mem_writeb_cmd_iccs(uint32_t val) "Initiator Command Complete Sequence (%2.2
 esp_mem_writeb_cmd_msgacc(uint32_t val) "Message Accepted (%2.2x)"
 esp_mem_writeb_cmd_pad(uint32_t val) "Transfer padding (%2.2x)"
 esp_mem_writeb_cmd_satn(uint32_t val) "Set ATN (%2.2x)"
+esp_mem_writeb_cmd_rstatn(uint32_t val) "Reset ATN (%2.2x)"
 esp_mem_writeb_cmd_sel(uint32_t val) "Select without ATN (%2.2x)"
 esp_mem_writeb_cmd_selatn(uint32_t val) "Select with ATN (%2.2x)"
 esp_mem_writeb_cmd_selatns(uint32_t val) "Select with ATN & stop (%2.2x)"
-- 
1.7.10

[Qemu-devel] [PATCH 3/7] esp: support future change of chip_id

[Hervé Poussineau]

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/esp.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/esp.c b/hw/esp.c
index e726e11..9a57938 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -50,6 +50,7 @@ struct ESPState {
     uint8_t wregs[ESP_REGS];
     qemu_irq irq;
     uint32_t it_shift;
+    uint8_t chip_id;
     int32_t ti_size;
     uint32_t ti_rptr, ti_wptr;
     uint32_t status;
@@ -470,7 +471,7 @@ static void esp_hard_reset(DeviceState *d)
 
     memset(s->rregs, 0, ESP_REGS);
     memset(s->wregs, 0, ESP_REGS);
-    s->rregs[ESP_TCHI] = TCHI_FAS100A; // Indicate fas100a
+    s->rregs[ESP_TCHI] = s->chip_id;
     s->ti_size = 0;
     s->ti_rptr = 0;
     s->ti_wptr = 0;
@@ -754,6 +755,7 @@ static int esp_init1(SysBusDevice *dev)
     sysbus_init_irq(dev, &s->irq);
     assert(s->it_shift != -1);
 
+    s->chip_id = TCHI_FAS100A;
     memory_region_init_io(&s->iomem, &esp_mem_ops, s,
                           "esp", ESP_REGS << s->it_shift);
     sysbus_init_mmio(dev, &s->iomem);
-- 
1.7.10

[Qemu-devel] [PATCH 4/7] esp: use hba_private field instead of a complex cast

[Hervé Poussineau]

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/esp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/esp.c b/hw/esp.c
index 9a57938..1b5403c 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -186,7 +186,7 @@ static void esp_dma_enable(void *opaque, int irq, int level)
 
 static void esp_request_cancelled(SCSIRequest *req)
 {
-    ESPState *s = DO_UPCAST(ESPState, busdev.qdev, req->bus->qbus.parent);
+    ESPState *s = req->hba_private;
 
     if (req == s->current_req) {
         scsi_req_unref(s->current_req);
@@ -242,7 +242,7 @@ static void do_busid_cmd(ESPState *s, uint8_t *buf, uint8_t busid)
     trace_esp_do_busid_cmd(busid);
     lun = busid & 7;
     current_lun = scsi_device_find(&s->bus, 0, s->current_dev->id, lun);
-    s->current_req = scsi_req_new(current_lun, 0, lun, buf, NULL);
+    s->current_req = scsi_req_new(current_lun, 0, lun, buf, s);
     datalen = scsi_req_enqueue(s->current_req);
     s->ti_size = datalen;
     if (datalen != 0) {
@@ -396,7 +396,7 @@ static void esp_do_dma(ESPState *s)
 static void esp_command_complete(SCSIRequest *req, uint32_t status,
                                  size_t resid)
 {
-    ESPState *s = DO_UPCAST(ESPState, busdev.qdev, req->bus->qbus.parent);
+    ESPState *s = req->hba_private;
 
     trace_esp_command_complete();
     if (s->ti_size != 0) {
@@ -420,7 +420,7 @@ static void esp_command_complete(SCSIRequest *req, uint32_t status,
 
 static void esp_transfer_data(SCSIRequest *req, uint32_t len)
 {
-    ESPState *s = DO_UPCAST(ESPState, busdev.qdev, req->bus->qbus.parent);
+    ESPState *s = req->hba_private;
 
     trace_esp_transfer_data(s->dma_left, s->ti_size);
     s->async_len = len;
-- 
1.7.10

[Qemu-devel] [PATCH 5/7] esp: split esp code into generic chip emulation and sysbus layer

[Hervé Poussineau]

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/esp.c |  162 ++++++++++++++++++++++++++++++++++++--------------------------
 1 file changed, 95 insertions(+), 67 deletions(-)

diff --git a/hw/esp.c b/hw/esp.c
index 1b5403c..714069b 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -44,12 +44,9 @@
 typedef struct ESPState ESPState;
 
 struct ESPState {
-    SysBusDevice busdev;
-    MemoryRegion iomem;
     uint8_t rregs[ESP_REGS];
     uint8_t wregs[ESP_REGS];
     qemu_irq irq;
-    uint32_t it_shift;
     uint8_t chip_id;
     int32_t ti_size;
     uint32_t ti_rptr, ti_wptr;
@@ -166,11 +163,8 @@ static void esp_lower_irq(ESPState *s)
     }
 }
 
-static void esp_dma_enable(void *opaque, int irq, int level)
+static void esp_dma_enable(ESPState *s, int irq, int level)
 {
-    DeviceState *d = opaque;
-    ESPState *s = container_of(d, ESPState, busdev.qdev);
-
     if (level) {
         s->dma_enabled = 1;
         trace_esp_dma_enable();
@@ -465,10 +459,8 @@ static void handle_ti(ESPState *s)
     }
 }
 
-static void esp_hard_reset(DeviceState *d)
+static void esp_hard_reset(ESPState *s)
 {
-    ESPState *s = container_of(d, ESPState, busdev.qdev);
-
     memset(s->rregs, 0, ESP_REGS);
     memset(s->wregs, 0, ESP_REGS);
     s->rregs[ESP_TCHI] = s->chip_id;
@@ -482,40 +474,23 @@ static void esp_hard_reset(DeviceState *d)
     s->rregs[ESP_CFG1] = 7;
 }
 
-static void esp_soft_reset(DeviceState *d)
+static void esp_soft_reset(ESPState *s)
 {
-    ESPState *s = container_of(d, ESPState, busdev.qdev);
-
     qemu_irq_lower(s->irq);
-    esp_hard_reset(d);
+    esp_hard_reset(s);
 }
 
-static void parent_esp_reset(void *opaque, int irq, int level)
+static void parent_esp_reset(ESPState *s, int irq, int level)
 {
     if (level) {
-        esp_soft_reset(opaque);
+        esp_soft_reset(s);
     }
 }
 
-static void esp_gpio_demux(void *opaque, int irq, int level)
+static uint64_t esp_reg_read(ESPState *s, uint32_t saddr)
 {
-    switch (irq) {
-    case 0:
-        parent_esp_reset(opaque, irq, level);
-        break;
-    case 1:
-        esp_dma_enable(opaque, irq, level);
-        break;
-    }
-}
+    uint32_t old_val;
 
-static uint64_t esp_mem_read(void *opaque, target_phys_addr_t addr,
-                             unsigned size)
-{
-    ESPState *s = opaque;
-    uint32_t saddr, old_val;
-
-    saddr = addr >> s->it_shift;
     trace_esp_mem_readb(saddr, s->rregs[saddr]);
     switch (saddr) {
     case ESP_FIFO:
@@ -551,13 +526,8 @@ static uint64_t esp_mem_read(void *opaque, target_phys_addr_t addr,
     return s->rregs[saddr];
 }
 
-static void esp_mem_write(void *opaque, target_phys_addr_t addr,
-                          uint64_t val, unsigned size)
+static void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t val)
 {
-    ESPState *s = opaque;
-    uint32_t saddr;
-
-    saddr = addr >> s->it_shift;
     trace_esp_mem_writeb(saddr, s->wregs[saddr], val);
     switch (saddr) {
     case ESP_TCLO:
@@ -597,7 +567,7 @@ static void esp_mem_write(void *opaque, target_phys_addr_t addr,
             break;
         case CMD_RESET:
             trace_esp_mem_writeb_cmd_reset(val);
-            esp_soft_reset(&s->busdev.qdev);
+            esp_soft_reset(s);
             break;
         case CMD_BUSRESET:
             trace_esp_mem_writeb_cmd_bus_reset(val);
@@ -683,13 +653,6 @@ static bool esp_mem_accepts(void *opaque, target_phys_addr_t addr,
     return (size == 1) || (is_write && size == 4);
 }
 
-static const MemoryRegionOps esp_mem_ops = {
-    .read = esp_mem_read,
-    .write = esp_mem_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
-    .valid.accepts = esp_mem_accepts,
-};
-
 static const VMStateDescription vmstate_esp = {
     .name ="esp",
     .version_id = 3,
@@ -712,6 +675,40 @@ static const VMStateDescription vmstate_esp = {
     }
 };
 
+typedef struct {
+    SysBusDevice busdev;
+    MemoryRegion iomem;
+    uint32_t it_shift;
+    ESPState esp;
+} SysBusESPState;
+
+static void sysbus_esp_mem_write(void *opaque, target_phys_addr_t addr,
+                                 uint64_t val, unsigned int size)
+{
+    SysBusESPState *sysbus = opaque;
+    uint32_t saddr;
+
+    saddr = addr >> sysbus->it_shift;
+    esp_reg_write(&sysbus->esp, saddr, val);
+}
+
+static uint64_t sysbus_esp_mem_read(void *opaque, target_phys_addr_t addr,
+                                    unsigned int size)
+{
+    SysBusESPState *sysbus = opaque;
+    uint32_t saddr;
+
+    saddr = addr >> sysbus->it_shift;
+    return esp_reg_read(&sysbus->esp, saddr);
+}
+
+static const MemoryRegionOps sysbus_esp_mem_ops = {
+    .read = sysbus_esp_mem_read,
+    .write = sysbus_esp_mem_write,
+    .endianness = DEVICE_NATIVE_ENDIAN,
+    .valid.accepts = esp_mem_accepts,
+};
+
 void esp_init(target_phys_addr_t espaddr, int it_shift,
               ESPDMAMemoryReadWriteFunc dma_memory_read,
               ESPDMAMemoryReadWriteFunc dma_memory_write,
@@ -720,14 +717,16 @@ void esp_init(target_phys_addr_t espaddr, int it_shift,
 {
     DeviceState *dev;
     SysBusDevice *s;
+    SysBusESPState *sysbus;
     ESPState *esp;
 
     dev = qdev_create(NULL, "esp");
-    esp = DO_UPCAST(ESPState, busdev.qdev, dev);
+    sysbus = DO_UPCAST(SysBusESPState, busdev.qdev, dev);
+    esp = &sysbus->esp;
     esp->dma_memory_read = dma_memory_read;
     esp->dma_memory_write = dma_memory_write;
     esp->dma_opaque = dma_opaque;
-    esp->it_shift = it_shift;
+    sysbus->it_shift = it_shift;
     /* XXX for now until rc4030 has been changed to use DMA enable signal */
     esp->dma_enabled = 1;
     qdev_init_nofail(dev);
@@ -748,49 +747,78 @@ static const struct SCSIBusInfo esp_scsi_info = {
     .cancel = esp_request_cancelled
 };
 
-static int esp_init1(SysBusDevice *dev)
+static void sysbus_esp_gpio_demux(void *opaque, int irq, int level)
 {
-    ESPState *s = FROM_SYSBUS(ESPState, dev);
+    DeviceState *d = opaque;
+    SysBusESPState *sysbus = container_of(d, SysBusESPState, busdev.qdev);
+    ESPState *s = &sysbus->esp;
+
+    switch (irq) {
+    case 0:
+        parent_esp_reset(s, irq, level);
+        break;
+    case 1:
+        esp_dma_enable(opaque, irq, level);
+        break;
+    }
+}
+
+static int sysbus_esp_init(SysBusDevice *dev)
+{
+    SysBusESPState *sysbus = FROM_SYSBUS(SysBusESPState, dev);
+    ESPState *s = &sysbus->esp;
 
     sysbus_init_irq(dev, &s->irq);
-    assert(s->it_shift != -1);
+    assert(sysbus->it_shift != -1);
 
     s->chip_id = TCHI_FAS100A;
-    memory_region_init_io(&s->iomem, &esp_mem_ops, s,
-                          "esp", ESP_REGS << s->it_shift);
-    sysbus_init_mmio(dev, &s->iomem);
+    memory_region_init_io(&sysbus->iomem, &sysbus_esp_mem_ops, sysbus,
+                          "esp", ESP_REGS << sysbus->it_shift);
+    sysbus_init_mmio(dev, &sysbus->iomem);
 
-    qdev_init_gpio_in(&dev->qdev, esp_gpio_demux, 2);
+    qdev_init_gpio_in(&dev->qdev, sysbus_esp_gpio_demux, 2);
 
     scsi_bus_new(&s->bus, &dev->qdev, &esp_scsi_info);
     return scsi_bus_legacy_handle_cmdline(&s->bus);
 }
 
-static Property esp_properties[] = {
-    {.name = NULL},
+static void sysbus_esp_hard_reset(DeviceState *dev)
+{
+    SysBusESPState *sysbus = DO_UPCAST(SysBusESPState, busdev.qdev, dev);
+    esp_hard_reset(&sysbus->esp);
+}
+
+static const VMStateDescription vmstate_sysbus_esp_scsi = {
+    .name = "sysbusespscsi",
+    .version_id = 0,
+    .minimum_version_id = 0,
+    .minimum_version_id_old = 0,
+    .fields = (VMStateField[]) {
+        VMSTATE_STRUCT(esp, SysBusESPState, 0, vmstate_esp, ESPState),
+        VMSTATE_END_OF_LIST()
+    }
 };
 
-static void esp_class_init(ObjectClass *klass, void *data)
+static void sysbus_esp_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc = DEVICE_CLASS(klass);
     SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
 
-    k->init = esp_init1;
-    dc->reset = esp_hard_reset;
-    dc->vmsd = &vmstate_esp;
-    dc->props = esp_properties;
+    k->init = sysbus_esp_init;
+    dc->reset = sysbus_esp_hard_reset;
+    dc->vmsd = &vmstate_sysbus_esp_scsi;
 }
 
-static TypeInfo esp_info = {
+static TypeInfo sysbus_esp_info = {
     .name          = "esp",
     .parent        = TYPE_SYS_BUS_DEVICE,
-    .instance_size = sizeof(ESPState),
-    .class_init    = esp_class_init,
+    .instance_size = sizeof(SysBusESPState),
+    .class_init    = sysbus_esp_class_init,
 };
 
 static void esp_register_types(void)
 {
-    type_register_static(&esp_info);
+    type_register_static(&sysbus_esp_info);
 }
 
 type_init(esp_register_types)
-- 
1.7.10

[Qemu-devel] [PATCH 6/7] esp: use error_report()/hw_error() instead of stderr output

[Hervé Poussineau]

Use error_report() for guest errors, hw_error() for unimplemented parts.

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/esp.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/hw/esp.c b/hw/esp.c
index 714069b..e3425bb 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -35,9 +35,6 @@
  * http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt
  */
 
-#define ESP_ERROR(fmt, ...)                                             \
-    do { printf("ESP ERROR: %s: " fmt, __func__ , ## __VA_ARGS__); } while (0)
-
 #define ESP_REGS 16
 #define TI_BUFSZ 16
 
@@ -498,7 +495,7 @@ static uint64_t esp_reg_read(ESPState *s, uint32_t saddr)
             s->ti_size--;
             if ((s->rregs[ESP_RSTAT] & STAT_PIO_MASK) == 0) {
                 /* Data out.  */
-                ESP_ERROR("PIO data read not implemented\n");
+                hw_error("esp: PIO data read not implemented");
                 s->rregs[ESP_FIFO] = 0;
             } else {
                 s->rregs[ESP_FIFO] = s->ti_buf[s->ti_rptr++];
@@ -538,7 +535,7 @@ static void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t val)
         if (s->do_cmd) {
             s->cmdbuf[s->cmdlen++] = val & 0xff;
         } else if (s->ti_size == TI_BUFSZ - 1) {
-            ESP_ERROR("fifo overrun\n");
+            error_report("esp: fifo overrun");
         } else {
             s->ti_size++;
             s->ti_buf[s->ti_wptr++] = val & 0xff;
@@ -626,7 +623,7 @@ static void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t val)
             esp_raise_irq(s);
             break;
         default:
-            ESP_ERROR("Unhandled ESP command (%2.2x)\n", (unsigned)val);
+            error_report("esp: unhandled command (%2.2x)", (unsigned)val);
             break;
         }
         break;
@@ -641,7 +638,8 @@ static void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t val)
         s->rregs[saddr] = val;
         break;
     default:
-        ESP_ERROR("invalid write of 0x%02x at [0x%x]\n", (unsigned)val, saddr);
+        error_report("esp: invalid write of 0x%02x at [0x%x]",
+                     (unsigned int)val, saddr);
         return;
     }
     s->wregs[saddr] = val;
-- 
1.7.10

[Qemu-devel] [PATCH 7/7] esp: add AMD PCscsi emulation (PCI SCSI adapter)

[Hervé Poussineau]

The PCI version is supported in lots of Operating Systems,
and has been successfully tested on:
- MS DOS 6.22 with MS Windows 3.11
- MS Windows 98 SE
- MS Windows NT 4.0

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 default-configs/i386-softmmu.mak |    1 +
 hw/esp.c                         |  340 +++++++++++++++++++++++++++++++++++++-
 hw/pci_ids.h                     |    1 +
 trace-events                     |    8 +
 4 files changed, 349 insertions(+), 1 deletion(-)

diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
index 2c78175..fee8cde 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -25,3 +25,4 @@ CONFIG_HPET=y
 CONFIG_APPLESMC=y
 CONFIG_I8259=y
 CONFIG_PFLASH_CFI01=y
+CONFIG_ESP=y
diff --git a/hw/esp.c b/hw/esp.c
index e3425bb..f5c00fa 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -2,6 +2,7 @@
  * QEMU ESP/NCR53C9x emulation
  *
  * Copyright (c) 2005-2006 Fabrice Bellard
+ * Copyright (c) 2012 Herve Poussineau
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -23,6 +24,7 @@
  */
 
 #include "sysbus.h"
+#include "pci.h"
 #include "scsi.h"
 #include "esp.h"
 #include "trace.h"
@@ -57,6 +59,7 @@ struct ESPState {
     uint32_t cmdlen;
     uint32_t do_cmd;
 
+    bool dma_autostart;
     /* The amount of data left in the current DMA transfer.  */
     uint32_t dma_left;
     /* The size of the current DMA transfer.  Zero if no transfer is in
@@ -141,6 +144,7 @@ struct ESPState {
 #define CFG1_RESREPT 0x40
 
 #define TCHI_FAS100A 0x4
+#define TCHI_AM53C974 0x12
 
 static void esp_raise_irq(ESPState *s)
 {
@@ -574,7 +578,9 @@ static void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t val)
             }
             break;
         case CMD_TI:
-            handle_ti(s);
+            if (!s->dma || s->dma_autostart) {
+                handle_ti(s);
+            }
             break;
         case CMD_ICCS:
             trace_esp_mem_writeb_cmd_iccs(val);
@@ -669,6 +675,7 @@ static const VMStateDescription vmstate_esp = {
         VMSTATE_UINT32(cmdlen, ESPState),
         VMSTATE_UINT32(do_cmd, ESPState),
         VMSTATE_UINT32(dma_left, ESPState),
+        VMSTATE_BOOL(dma_autostart, ESPState),
         VMSTATE_END_OF_LIST()
     }
 };
@@ -770,6 +777,7 @@ static int sysbus_esp_init(SysBusDevice *dev)
     assert(sysbus->it_shift != -1);
 
     s->chip_id = TCHI_FAS100A;
+    s->dma_autostart = true;
     memory_region_init_io(&sysbus->iomem, &sysbus_esp_mem_ops, sysbus,
                           "esp", ESP_REGS << sysbus->it_shift);
     sysbus_init_mmio(dev, &sysbus->iomem);
@@ -814,9 +822,339 @@ static TypeInfo sysbus_esp_info = {
     .class_init    = sysbus_esp_class_init,
 };
 
+#define DMA_CMD   0x0
+#define DMA_STC   0x1
+#define DMA_SPA   0x2
+#define DMA_WBC   0x3
+#define DMA_WAC   0x4
+#define DMA_STAT  0x5
+#define DMA_SMDLA 0x6
+#define DMA_WMAC  0x7
+
+#define DMA_CMD_MASK   0x03
+#define DMA_CMD_DIAG   0x04
+#define DMA_CMD_MDL    0x10
+#define DMA_CMD_INTE_P 0x20
+#define DMA_CMD_INTE_D 0x40
+#define DMA_CMD_DIR    0x80
+
+#define DMA_STAT_PWDN    0x01
+#define DMA_STAT_ERROR   0x02
+#define DMA_STAT_ABORT   0x04
+#define DMA_STAT_DONE    0x08
+#define DMA_STAT_SCSIINT 0x10
+#define DMA_STAT_BCMBLT  0x20
+
+#define SBAC_STATUS 0x1000
+
+typedef struct {
+    PCIDevice dev;
+    MemoryRegion io;
+    uint32_t dma_regs[8];
+    uint32_t sbac;
+    ESPState esp;
+} PCIESPState;
+
+static void pci_handle_start(PCIESPState *pci, uint32_t val)
+{
+    trace_esp_pci_dma_start(val);
+
+    pci->dma_regs[DMA_WBC] = pci->dma_regs[DMA_STC];
+    pci->dma_regs[DMA_WAC] = pci->dma_regs[DMA_SPA];
+    pci->dma_regs[DMA_WMAC] = pci->dma_regs[DMA_SMDLA];
+
+    pci->dma_regs[DMA_STAT] &= ~(DMA_STAT_BCMBLT | DMA_STAT_SCSIINT
+                               | DMA_STAT_DONE | DMA_STAT_ABORT
+                               | DMA_STAT_ERROR | DMA_STAT_PWDN);
+
+    handle_ti(&pci->esp);
+}
+
+static void pci_handle_blast(PCIESPState *pci, uint32_t val)
+{
+    trace_esp_pci_dma_blast(val);
+    hw_error("am53c974: cmd BLAST not implemented");
+}
+
+static void pci_handle_abort(PCIESPState *pci, uint32_t val)
+{
+    trace_esp_pci_dma_abort(val);
+    if (pci->esp.current_req) {
+        scsi_req_cancel(pci->esp.current_req);
+    }
+}
+
+static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint32_t val)
+{
+    trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
+    switch (saddr) {
+    case DMA_CMD:
+        pci->dma_regs[saddr] = val;
+        switch (val & DMA_CMD_MASK) {
+        case 0x0: /* IDLE */
+            trace_esp_pci_dma_idle(val);
+            break;
+        case 0x1: /* BLAST */
+            pci_handle_blast(pci, val);
+        case 0x2: /* ABORT */
+            pci_handle_abort(pci, val);
+        case 0x3: /* START */
+            pci_handle_start(pci, val);
+            break;
+        default:
+            error_report("am53c974: unhandled command (%2.2x)",
+                         val & DMA_CMD_MASK);
+            break;
+        }
+        break;
+    case DMA_STC:
+    case DMA_SPA:
+    case DMA_SMDLA:
+        pci->dma_regs[saddr] = val;
+        break;
+    case DMA_STAT:
+        if (!(pci->sbac & SBAC_STATUS)) {
+            /* clear some bits on write */
+            uint32_t mask = DMA_STAT_ERROR | DMA_STAT_ABORT | DMA_STAT_DONE;
+            pci->dma_regs[DMA_STAT] &= ~(val & mask);
+        }
+        break;
+    default:
+        error_report("am53c974: invalid write of 0x%08x at [0x%x]", val, saddr);
+        return;
+    }
+}
+
+static uint32_t pci_esp_dma_read(PCIESPState *pci, uint32_t saddr)
+{
+    uint32_t val;
+
+    val = pci->dma_regs[saddr];
+    if (saddr == DMA_STAT) {
+        if (pci->esp.rregs[ESP_RSTAT] & STAT_INT) {
+            val |= DMA_STAT_SCSIINT;
+        }
+        if (pci->sbac & SBAC_STATUS) {
+            pci->dma_regs[DMA_STAT] &= ~(DMA_STAT_ERROR | DMA_STAT_ABORT |
+                                         DMA_STAT_DONE);
+        }
+    }
+
+    trace_esp_pci_dma_read(saddr, val);
+    return val;
+}
+
+static void pci_esp_io_write(void *opaque, target_phys_addr_t addr,
+                             uint64_t val, unsigned int size)
+{
+    PCIESPState *pci = opaque;
+
+    if (addr < 0x40) {
+        /* SCSI core reg */
+        esp_reg_write(&pci->esp, addr >> 2, val);
+    } else if (addr < 0x60) {
+        /* PCI DMA CCB */
+        pci_esp_dma_write(pci, (addr - 0x40) >> 2, val);
+    } else if (addr == 0x70) {
+        /* DMA SCSI Bus and control */
+        trace_esp_pci_sbac_write(pci->sbac, val);
+        pci->sbac = val;
+    } else {
+        error_report("am53c974: write access outside bounds (reg 0x%x)",
+                     (int)addr);
+    }
+}
+
+static uint64_t pci_esp_io_read(void *opaque, target_phys_addr_t addr,
+                                unsigned int size)
+{
+    PCIESPState *pci = opaque;
+
+    if (addr < 0x40) {
+        /* SCSI core reg */
+        return esp_reg_read(&pci->esp, addr >> 2);
+    } else if (addr < 0x60) {
+        /* PCI DMA CCB */
+        return pci_esp_dma_read(pci, (addr - 0x40) >> 2);
+    } else if (addr == 0x70) {
+        /* DMA SCSI Bus and control */
+        trace_esp_pci_sbac_read(pci->sbac);
+        return pci->sbac;
+    } else {
+        /* Invalid region */
+        error_report("am53c974: read access outside bounds (reg 0x%x)",
+                     (int)addr);
+        return 0;
+    }
+}
+
+static void pci_esp_dma_memory_rw(PCIESPState *pci, uint8_t *buf, int len,
+                                  DMADirection dir)
+{
+    dma_addr_t addr;
+    DMADirection expected_dir;
+
+    if (pci->dma_regs[DMA_CMD] & DMA_CMD_DIR) {
+        expected_dir = DMA_DIRECTION_FROM_DEVICE;
+    } else {
+        expected_dir = DMA_DIRECTION_TO_DEVICE;
+    }
+
+    if (dir != expected_dir) {
+        error_report("am53c974: invalid dma transfer direction");
+        return;
+    }
+
+    if (pci->dma_regs[DMA_STAT] & DMA_CMD_MDL) {
+        hw_error("am53c974: MDL transfer not implemented");
+    }
+
+    addr = pci->dma_regs[DMA_SPA];
+    if (pci->dma_regs[DMA_WBC] < len) {
+        len = pci->dma_regs[DMA_WBC];
+    }
+
+    pci_dma_rw(&pci->dev, addr, buf, len, dir);
+
+    /* update status registers */
+    pci->dma_regs[DMA_WBC] -= len;
+    pci->dma_regs[DMA_WAC] += len;
+}
+
+static void pci_esp_dma_memory_read(void *opaque, uint8_t *buf, int len)
+{
+    PCIESPState *pci = opaque;
+    pci_esp_dma_memory_rw(pci, buf, len, DMA_DIRECTION_TO_DEVICE);
+}
+
+static void pci_esp_dma_memory_write(void *opaque, uint8_t *buf, int len)
+{
+    PCIESPState *pci = opaque;
+    pci_esp_dma_memory_rw(pci, buf, len, DMA_DIRECTION_FROM_DEVICE);
+}
+
+static const MemoryRegionOps pci_esp_io_ops = {
+    .read = pci_esp_io_read,
+    .write = pci_esp_io_write,
+    .endianness = DEVICE_LITTLE_ENDIAN,
+    .impl = {
+        .min_access_size = 4,
+        .max_access_size = 4,
+    },
+};
+
+static void pci_esp_hard_reset(DeviceState *dev)
+{
+    PCIESPState *pci = DO_UPCAST(PCIESPState, dev.qdev, dev);
+    esp_hard_reset(&pci->esp);
+    pci->esp.dma_enabled = 1;
+    pci->dma_regs[DMA_CMD] &= ~(DMA_CMD_DIR | DMA_CMD_INTE_D | DMA_CMD_INTE_P
+                              | DMA_CMD_MDL | DMA_CMD_DIAG | DMA_CMD_MASK);
+    pci->dma_regs[DMA_WBC] &= ~0xffff;
+    pci->dma_regs[DMA_WAC] = 0xffffffff;
+    pci->dma_regs[DMA_STAT] &= ~(DMA_STAT_BCMBLT | DMA_STAT_SCSIINT
+                               | DMA_STAT_DONE | DMA_STAT_ABORT
+                               | DMA_STAT_ERROR);
+    pci->dma_regs[DMA_WMAC] = 0xfffffffd;
+}
+
+static const VMStateDescription vmstate_pci_esp_scsi = {
+    .name = "pciespscsi",
+    .version_id = 0,
+    .minimum_version_id = 0,
+    .minimum_version_id_old = 0,
+    .fields = (VMStateField[]) {
+        VMSTATE_PCI_DEVICE(dev, PCIESPState),
+        VMSTATE_BUFFER_UNSAFE(dma_regs, PCIESPState, 0, 8 * sizeof(uint32_t)),
+        VMSTATE_STRUCT(esp, PCIESPState, 0, vmstate_esp, ESPState),
+        VMSTATE_END_OF_LIST()
+    }
+};
+
+static void pci_esp_command_complete(SCSIRequest *req, uint32_t status,
+                                     size_t resid)
+{
+    ESPState *s = req->hba_private;
+    PCIESPState *pci = container_of(s, PCIESPState, esp);
+
+    esp_command_complete(req, status, resid);
+    pci->dma_regs[DMA_WBC] = 0;
+    pci->dma_regs[DMA_STAT] |= DMA_STAT_DONE;
+}
+
+static const struct SCSIBusInfo pci_esp_scsi_info = {
+    .tcq = false,
+    .max_target = ESP_MAX_DEVS,
+    .max_lun = 7,
+
+    .transfer_data = esp_transfer_data,
+    .complete = pci_esp_command_complete,
+    .cancel = esp_request_cancelled
+};
+
+static int pci_esp_scsi_init(PCIDevice *dev)
+{
+    PCIESPState *pci = DO_UPCAST(PCIESPState, dev, dev);
+    ESPState *s = &pci->esp;
+    uint8_t *pci_conf;
+
+    pci_conf = pci->dev.config;
+
+    /* Interrupt pin A */
+    pci_conf[PCI_INTERRUPT_PIN] = 0x01;
+
+    s->dma_memory_read = pci_esp_dma_memory_read;
+    s->dma_memory_write = pci_esp_dma_memory_write;
+    s->dma_opaque = pci;
+    s->chip_id = TCHI_AM53C974;
+    memory_region_init_io(&pci->io, &pci_esp_io_ops, pci, "esp-io", 0x80);
+
+    pci_register_bar(&pci->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &pci->io);
+    s->irq = pci->dev.irq[0];
+
+    scsi_bus_new(&s->bus, &dev->qdev, &pci_esp_scsi_info);
+    if (!dev->qdev.hotplugged) {
+        return scsi_bus_legacy_handle_cmdline(&s->bus);
+    }
+    return 0;
+}
+
+static int pci_esp_scsi_uninit(PCIDevice *d)
+{
+    PCIESPState *pci = DO_UPCAST(PCIESPState, dev, d);
+
+    memory_region_destroy(&pci->io);
+
+    return 0;
+}
+
+static void pci_esp_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+    PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
+
+    k->init = pci_esp_scsi_init;
+    k->exit = pci_esp_scsi_uninit;
+    k->vendor_id = PCI_VENDOR_ID_AMD;
+    k->device_id = PCI_DEVICE_ID_AMD_SCSI;
+    k->revision = 0x10;
+    k->class_id = PCI_CLASS_STORAGE_SCSI;
+    dc->desc = "AMD Am53c974 PCscsi-PCI SCSI adapter";
+    dc->reset = pci_esp_hard_reset;
+    dc->vmsd = &vmstate_pci_esp_scsi;
+}
+
+static TypeInfo pci_esp_info = {
+    .name = "am53c974",
+    .parent = TYPE_PCI_DEVICE,
+    .instance_size = sizeof(PCIESPState),
+    .class_init = pci_esp_class_init,
+};
+
 static void esp_register_types(void)
 {
     type_register_static(&sysbus_esp_info);
+    type_register_static(&pci_esp_info);
 }
 
 type_init(esp_register_types)
diff --git a/hw/pci_ids.h b/hw/pci_ids.h
index e8235a7..9d6e30b 100644
--- a/hw/pci_ids.h
+++ b/hw/pci_ids.h
@@ -57,6 +57,7 @@
 
 #define PCI_VENDOR_ID_AMD                0x1022
 #define PCI_DEVICE_ID_AMD_LANCE          0x2000
+#define PCI_DEVICE_ID_AMD_SCSI           0x2020
 
 #define PCI_VENDOR_ID_TI                 0x104c
 
diff --git a/trace-events b/trace-events
index 81780f0..8acb647 100644
--- a/trace-events
+++ b/trace-events
@@ -639,6 +639,14 @@ esp_mem_writeb_cmd_selatn(uint32_t val) "Select with ATN (%2.2x)"
 esp_mem_writeb_cmd_selatns(uint32_t val) "Select with ATN & stop (%2.2x)"
 esp_mem_writeb_cmd_ensel(uint32_t val) "Enable selection (%2.2x)"
 esp_mem_writeb_cmd_dissel(uint32_t val) "Disable selection (%2.2x)"
+esp_pci_dma_read(uint32_t saddr, uint32_t reg) "reg[%d]: 0x%8.8x"
+esp_pci_dma_write(uint32_t saddr, uint32_t reg, uint32_t val) "reg[%d]: 0x%8.8x -> 0x%8.8x"
+esp_pci_dma_idle(uint32_t val) "IDLE (%.8x)"
+esp_pci_dma_blast(uint32_t val) "BLAST (%.8x)"
+esp_pci_dma_abort(uint32_t val) "ABORT (%.8x)"
+esp_pci_dma_start(uint32_t val) "START (%.8x)"
+esp_pci_sbac_read(uint32_t reg) "sbac: 0x%8.8x"
+esp_pci_sbac_write(uint32_t reg, uint32_t val) "sbac: 0x%8.8x -> 0x%8.8x"
 
 # monitor.c
 handle_qmp_command(void *mon, const char *cmd_name) "mon %p cmd_name \"%s\""
-- 
1.7.10

Re: [Qemu-devel] [PATCH 7/7] esp: add AMD PCscsi emulation (PCI SCSI adapter)

[Michael S. Tsirkin]

On Sun, Jun 03, 2012 at 12:38:09PM +0200, Hervé Poussineau wrote:
> The PCI version is supported in lots of Operating Systems,
> and has been successfully tested on:
> - MS DOS 6.22 with MS Windows 3.11
> - MS Windows 98 SE
> - MS Windows NT 4.0
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

I'm not sure why I'm Cc'd - for the pci_ids changes?
These look fine to me.
Some minor suggestions below but I only looked at it
briefly.
I don't have the time to do a proper review ATM, sorry.

> ---
>  default-configs/i386-softmmu.mak |    1 +
>  hw/esp.c                         |  340 +++++++++++++++++++++++++++++++++++++-
>  hw/pci_ids.h                     |    1 +
>  trace-events                     |    8 +
>  4 files changed, 349 insertions(+), 1 deletion(-)
> 
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
> index 2c78175..fee8cde 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -25,3 +25,4 @@ CONFIG_HPET=y
>  CONFIG_APPLESMC=y
>  CONFIG_I8259=y
>  CONFIG_PFLASH_CFI01=y
> +CONFIG_ESP=y
> diff --git a/hw/esp.c b/hw/esp.c
> index e3425bb..f5c00fa 100644
> --- a/hw/esp.c
> +++ b/hw/esp.c
> @@ -2,6 +2,7 @@
>   * QEMU ESP/NCR53C9x emulation
>   *
>   * Copyright (c) 2005-2006 Fabrice Bellard
> + * Copyright (c) 2012 Herve Poussineau
>   *
>   * Permission is hereby granted, free of charge, to any person obtaining a copy
>   * of this software and associated documentation files (the "Software"), to deal
> @@ -23,6 +24,7 @@
>   */
>  
>  #include "sysbus.h"
> +#include "pci.h"
>  #include "scsi.h"
>  #include "esp.h"
>  #include "trace.h"
> @@ -57,6 +59,7 @@ struct ESPState {
>      uint32_t cmdlen;
>      uint32_t do_cmd;
>  
> +    bool dma_autostart;
>      /* The amount of data left in the current DMA transfer.  */
>      uint32_t dma_left;
>      /* The size of the current DMA transfer.  Zero if no transfer is in
> @@ -141,6 +144,7 @@ struct ESPState {
>  #define CFG1_RESREPT 0x40
>  
>  #define TCHI_FAS100A 0x4
> +#define TCHI_AM53C974 0x12
>  
>  static void esp_raise_irq(ESPState *s)
>  {
> @@ -574,7 +578,9 @@ static void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t val)
>              }
>              break;
>          case CMD_TI:
> -            handle_ti(s);
> +            if (!s->dma || s->dma_autostart) {
> +                handle_ti(s);
> +            }
>              break;
>          case CMD_ICCS:
>              trace_esp_mem_writeb_cmd_iccs(val);
> @@ -669,6 +675,7 @@ static const VMStateDescription vmstate_esp = {
>          VMSTATE_UINT32(cmdlen, ESPState),
>          VMSTATE_UINT32(do_cmd, ESPState),
>          VMSTATE_UINT32(dma_left, ESPState),
> +        VMSTATE_BOOL(dma_autostart, ESPState),
>          VMSTATE_END_OF_LIST()
>      }
>  };
> @@ -770,6 +777,7 @@ static int sysbus_esp_init(SysBusDevice *dev)
>      assert(sysbus->it_shift != -1);
>  
>      s->chip_id = TCHI_FAS100A;
> +    s->dma_autostart = true;
>      memory_region_init_io(&sysbus->iomem, &sysbus_esp_mem_ops, sysbus,
>                            "esp", ESP_REGS << sysbus->it_shift);
>      sysbus_init_mmio(dev, &sysbus->iomem);
> @@ -814,9 +822,339 @@ static TypeInfo sysbus_esp_info = {
>      .class_init    = sysbus_esp_class_init,
>  };
>  
> +#define DMA_CMD   0x0
> +#define DMA_STC   0x1
> +#define DMA_SPA   0x2
> +#define DMA_WBC   0x3
> +#define DMA_WAC   0x4
> +#define DMA_STAT  0x5
> +#define DMA_SMDLA 0x6
> +#define DMA_WMAC  0x7
> +
> +#define DMA_CMD_MASK   0x03
> +#define DMA_CMD_DIAG   0x04
> +#define DMA_CMD_MDL    0x10
> +#define DMA_CMD_INTE_P 0x20
> +#define DMA_CMD_INTE_D 0x40
> +#define DMA_CMD_DIR    0x80
> +
> +#define DMA_STAT_PWDN    0x01
> +#define DMA_STAT_ERROR   0x02
> +#define DMA_STAT_ABORT   0x04
> +#define DMA_STAT_DONE    0x08
> +#define DMA_STAT_SCSIINT 0x10
> +#define DMA_STAT_BCMBLT  0x20
> +
> +#define SBAC_STATUS 0x1000
> +
> +typedef struct {
> +    PCIDevice dev;
> +    MemoryRegion io;
> +    uint32_t dma_regs[8];
> +    uint32_t sbac;
> +    ESPState esp;
> +} PCIESPState;

minor: preferable typedef struct PCIESPState PCIESPState;

> +
> +static void pci_handle_start(PCIESPState *pci, uint32_t val)
> +{
> +    trace_esp_pci_dma_start(val);
> +
> +    pci->dma_regs[DMA_WBC] = pci->dma_regs[DMA_STC];
> +    pci->dma_regs[DMA_WAC] = pci->dma_regs[DMA_SPA];
> +    pci->dma_regs[DMA_WMAC] = pci->dma_regs[DMA_SMDLA];
> +
> +    pci->dma_regs[DMA_STAT] &= ~(DMA_STAT_BCMBLT | DMA_STAT_SCSIINT
> +                               | DMA_STAT_DONE | DMA_STAT_ABORT
> +                               | DMA_STAT_ERROR | DMA_STAT_PWDN);
> +
> +    handle_ti(&pci->esp);
> +}
> +
> +static void pci_handle_blast(PCIESPState *pci, uint32_t val)
> +{
> +    trace_esp_pci_dma_blast(val);
> +    hw_error("am53c974: cmd BLAST not implemented");
> +}
> +
> +static void pci_handle_abort(PCIESPState *pci, uint32_t val)
> +{
> +    trace_esp_pci_dma_abort(val);
> +    if (pci->esp.current_req) {
> +        scsi_req_cancel(pci->esp.current_req);
> +    }
> +}
> +

It is better to prefix all global scope symbols with
esp_ consistently. Reduces the chance of a conflict.

> +static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint32_t val)
> +{
> +    trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
> +    switch (saddr) {
> +    case DMA_CMD:
> +        pci->dma_regs[saddr] = val;
> +        switch (val & DMA_CMD_MASK) {
> +        case 0x0: /* IDLE */
> +            trace_esp_pci_dma_idle(val);
> +            break;
> +        case 0x1: /* BLAST */
> +            pci_handle_blast(pci, val);

fall-through intentional?

> +        case 0x2: /* ABORT */
> +            pci_handle_abort(pci, val);
> +        case 0x3: /* START */
> +            pci_handle_start(pci, val);
> +            break;
> +        default:
> +            error_report("am53c974: unhandled command (%2.2x)",
> +                         val & DMA_CMD_MASK);
> +            break;
> +        }
> +        break;
> +    case DMA_STC:
> +    case DMA_SPA:
> +    case DMA_SMDLA:
> +        pci->dma_regs[saddr] = val;
> +        break;
> +    case DMA_STAT:
> +        if (!(pci->sbac & SBAC_STATUS)) {
> +            /* clear some bits on write */
> +            uint32_t mask = DMA_STAT_ERROR | DMA_STAT_ABORT | DMA_STAT_DONE;
> +            pci->dma_regs[DMA_STAT] &= ~(val & mask);
> +        }
> +        break;
> +    default:
> +        error_report("am53c974: invalid write of 0x%08x at [0x%x]", val, saddr);
> +        return;
> +    }
> +}
> +
> +static uint32_t pci_esp_dma_read(PCIESPState *pci, uint32_t saddr)
> +{
> +    uint32_t val;
> +
> +    val = pci->dma_regs[saddr];
> +    if (saddr == DMA_STAT) {
> +        if (pci->esp.rregs[ESP_RSTAT] & STAT_INT) {
> +            val |= DMA_STAT_SCSIINT;
> +        }
> +        if (pci->sbac & SBAC_STATUS) {
> +            pci->dma_regs[DMA_STAT] &= ~(DMA_STAT_ERROR | DMA_STAT_ABORT |
> +                                         DMA_STAT_DONE);
> +        }
> +    }
> +
> +    trace_esp_pci_dma_read(saddr, val);
> +    return val;
> +}
> +
> +static void pci_esp_io_write(void *opaque, target_phys_addr_t addr,
> +                             uint64_t val, unsigned int size)
> +{
> +    PCIESPState *pci = opaque;
> +
> +    if (addr < 0x40) {
> +        /* SCSI core reg */
> +        esp_reg_write(&pci->esp, addr >> 2, val);
> +    } else if (addr < 0x60) {
> +        /* PCI DMA CCB */
> +        pci_esp_dma_write(pci, (addr - 0x40) >> 2, val);
> +    } else if (addr == 0x70) {
> +        /* DMA SCSI Bus and control */
> +        trace_esp_pci_sbac_write(pci->sbac, val);
> +        pci->sbac = val;
> +    } else {
> +        error_report("am53c974: write access outside bounds (reg 0x%x)",
> +                     (int)addr);
> +    }
> +}
> +
> +static uint64_t pci_esp_io_read(void *opaque, target_phys_addr_t addr,
> +                                unsigned int size)
> +{
> +    PCIESPState *pci = opaque;
> +
> +    if (addr < 0x40) {
> +        /* SCSI core reg */
> +        return esp_reg_read(&pci->esp, addr >> 2);
> +    } else if (addr < 0x60) {
> +        /* PCI DMA CCB */
> +        return pci_esp_dma_read(pci, (addr - 0x40) >> 2);
> +    } else if (addr == 0x70) {
> +        /* DMA SCSI Bus and control */
> +        trace_esp_pci_sbac_read(pci->sbac);
> +        return pci->sbac;
> +    } else {
> +        /* Invalid region */
> +        error_report("am53c974: read access outside bounds (reg 0x%x)",
> +                     (int)addr);
> +        return 0;
> +    }
> +}
> +
> +static void pci_esp_dma_memory_rw(PCIESPState *pci, uint8_t *buf, int len,
> +                                  DMADirection dir)
> +{
> +    dma_addr_t addr;
> +    DMADirection expected_dir;
> +
> +    if (pci->dma_regs[DMA_CMD] & DMA_CMD_DIR) {
> +        expected_dir = DMA_DIRECTION_FROM_DEVICE;
> +    } else {
> +        expected_dir = DMA_DIRECTION_TO_DEVICE;
> +    }
> +
> +    if (dir != expected_dir) {
> +        error_report("am53c974: invalid dma transfer direction");
> +        return;
> +    }
> +
> +    if (pci->dma_regs[DMA_STAT] & DMA_CMD_MDL) {
> +        hw_error("am53c974: MDL transfer not implemented");
> +    }
> +
> +    addr = pci->dma_regs[DMA_SPA];
> +    if (pci->dma_regs[DMA_WBC] < len) {
> +        len = pci->dma_regs[DMA_WBC];
> +    }
> +
> +    pci_dma_rw(&pci->dev, addr, buf, len, dir);
> +
> +    /* update status registers */
> +    pci->dma_regs[DMA_WBC] -= len;
> +    pci->dma_regs[DMA_WAC] += len;
> +}
> +
> +static void pci_esp_dma_memory_read(void *opaque, uint8_t *buf, int len)
> +{
> +    PCIESPState *pci = opaque;
> +    pci_esp_dma_memory_rw(pci, buf, len, DMA_DIRECTION_TO_DEVICE);
> +}
> +
> +static void pci_esp_dma_memory_write(void *opaque, uint8_t *buf, int len)
> +{
> +    PCIESPState *pci = opaque;
> +    pci_esp_dma_memory_rw(pci, buf, len, DMA_DIRECTION_FROM_DEVICE);
> +}
> +
> +static const MemoryRegionOps pci_esp_io_ops = {
> +    .read = pci_esp_io_read,
> +    .write = pci_esp_io_write,
> +    .endianness = DEVICE_LITTLE_ENDIAN,
> +    .impl = {
> +        .min_access_size = 4,
> +        .max_access_size = 4,
> +    },
> +};
> +
> +static void pci_esp_hard_reset(DeviceState *dev)
> +{
> +    PCIESPState *pci = DO_UPCAST(PCIESPState, dev.qdev, dev);
> +    esp_hard_reset(&pci->esp);
> +    pci->esp.dma_enabled = 1;
> +    pci->dma_regs[DMA_CMD] &= ~(DMA_CMD_DIR | DMA_CMD_INTE_D | DMA_CMD_INTE_P
> +                              | DMA_CMD_MDL | DMA_CMD_DIAG | DMA_CMD_MASK);
> +    pci->dma_regs[DMA_WBC] &= ~0xffff;
> +    pci->dma_regs[DMA_WAC] = 0xffffffff;
> +    pci->dma_regs[DMA_STAT] &= ~(DMA_STAT_BCMBLT | DMA_STAT_SCSIINT
> +                               | DMA_STAT_DONE | DMA_STAT_ABORT
> +                               | DMA_STAT_ERROR);
> +    pci->dma_regs[DMA_WMAC] = 0xfffffffd;
> +}
> +
> +static const VMStateDescription vmstate_pci_esp_scsi = {
> +    .name = "pciespscsi",
> +    .version_id = 0,
> +    .minimum_version_id = 0,
> +    .minimum_version_id_old = 0,
> +    .fields = (VMStateField[]) {
> +        VMSTATE_PCI_DEVICE(dev, PCIESPState),
> +        VMSTATE_BUFFER_UNSAFE(dma_regs, PCIESPState, 0, 8 * sizeof(uint32_t)),
> +        VMSTATE_STRUCT(esp, PCIESPState, 0, vmstate_esp, ESPState),
> +        VMSTATE_END_OF_LIST()
> +    }
> +};
> +
> +static void pci_esp_command_complete(SCSIRequest *req, uint32_t status,
> +                                     size_t resid)
> +{
> +    ESPState *s = req->hba_private;
> +    PCIESPState *pci = container_of(s, PCIESPState, esp);
> +
> +    esp_command_complete(req, status, resid);
> +    pci->dma_regs[DMA_WBC] = 0;
> +    pci->dma_regs[DMA_STAT] |= DMA_STAT_DONE;
> +}
> +
> +static const struct SCSIBusInfo pci_esp_scsi_info = {
> +    .tcq = false,
> +    .max_target = ESP_MAX_DEVS,
> +    .max_lun = 7,
> +
> +    .transfer_data = esp_transfer_data,
> +    .complete = pci_esp_command_complete,
> +    .cancel = esp_request_cancelled
> +};
> +
> +static int pci_esp_scsi_init(PCIDevice *dev)
> +{
> +    PCIESPState *pci = DO_UPCAST(PCIESPState, dev, dev);
> +    ESPState *s = &pci->esp;
> +    uint8_t *pci_conf;
> +
> +    pci_conf = pci->dev.config;
> +
> +    /* Interrupt pin A */
> +    pci_conf[PCI_INTERRUPT_PIN] = 0x01;
> +
> +    s->dma_memory_read = pci_esp_dma_memory_read;
> +    s->dma_memory_write = pci_esp_dma_memory_write;
> +    s->dma_opaque = pci;
> +    s->chip_id = TCHI_AM53C974;
> +    memory_region_init_io(&pci->io, &pci_esp_io_ops, pci, "esp-io", 0x80);
> +
> +    pci_register_bar(&pci->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &pci->io);
> +    s->irq = pci->dev.irq[0];
> +
> +    scsi_bus_new(&s->bus, &dev->qdev, &pci_esp_scsi_info);
> +    if (!dev->qdev.hotplugged) {
> +        return scsi_bus_legacy_handle_cmdline(&s->bus);
> +    }
> +    return 0;
> +}
> +
> +static int pci_esp_scsi_uninit(PCIDevice *d)
> +{
> +    PCIESPState *pci = DO_UPCAST(PCIESPState, dev, d);
> +
> +    memory_region_destroy(&pci->io);
> +
> +    return 0;
> +}
> +
> +static void pci_esp_class_init(ObjectClass *klass, void *data)
> +{
> +    DeviceClass *dc = DEVICE_CLASS(klass);
> +    PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> +
> +    k->init = pci_esp_scsi_init;
> +    k->exit = pci_esp_scsi_uninit;
> +    k->vendor_id = PCI_VENDOR_ID_AMD;
> +    k->device_id = PCI_DEVICE_ID_AMD_SCSI;
> +    k->revision = 0x10;
> +    k->class_id = PCI_CLASS_STORAGE_SCSI;
> +    dc->desc = "AMD Am53c974 PCscsi-PCI SCSI adapter";
> +    dc->reset = pci_esp_hard_reset;
> +    dc->vmsd = &vmstate_pci_esp_scsi;
> +}
> +
> +static TypeInfo pci_esp_info = {
> +    .name = "am53c974",
> +    .parent = TYPE_PCI_DEVICE,
> +    .instance_size = sizeof(PCIESPState),
> +    .class_init = pci_esp_class_init,
> +};
> +
>  static void esp_register_types(void)
>  {
>      type_register_static(&sysbus_esp_info);
> +    type_register_static(&pci_esp_info);
>  }
>  
>  type_init(esp_register_types)
> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> index e8235a7..9d6e30b 100644
> --- a/hw/pci_ids.h
> +++ b/hw/pci_ids.h
> @@ -57,6 +57,7 @@
>  
>  #define PCI_VENDOR_ID_AMD                0x1022
>  #define PCI_DEVICE_ID_AMD_LANCE          0x2000
> +#define PCI_DEVICE_ID_AMD_SCSI           0x2020
>  
>  #define PCI_VENDOR_ID_TI                 0x104c
>  
> diff --git a/trace-events b/trace-events
> index 81780f0..8acb647 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -639,6 +639,14 @@ esp_mem_writeb_cmd_selatn(uint32_t val) "Select with ATN (%2.2x)"
>  esp_mem_writeb_cmd_selatns(uint32_t val) "Select with ATN & stop (%2.2x)"
>  esp_mem_writeb_cmd_ensel(uint32_t val) "Enable selection (%2.2x)"
>  esp_mem_writeb_cmd_dissel(uint32_t val) "Disable selection (%2.2x)"
> +esp_pci_dma_read(uint32_t saddr, uint32_t reg) "reg[%d]: 0x%8.8x"
> +esp_pci_dma_write(uint32_t saddr, uint32_t reg, uint32_t val) "reg[%d]: 0x%8.8x -> 0x%8.8x"
> +esp_pci_dma_idle(uint32_t val) "IDLE (%.8x)"
> +esp_pci_dma_blast(uint32_t val) "BLAST (%.8x)"
> +esp_pci_dma_abort(uint32_t val) "ABORT (%.8x)"
> +esp_pci_dma_start(uint32_t val) "START (%.8x)"
> +esp_pci_sbac_read(uint32_t reg) "sbac: 0x%8.8x"
> +esp_pci_sbac_write(uint32_t reg, uint32_t val) "sbac: 0x%8.8x -> 0x%8.8x"
>  
>  # monitor.c
>  handle_qmp_command(void *mon, const char *cmd_name) "mon %p cmd_name \"%s\""
> -- 
> 1.7.10

Re: [Qemu-devel] [PATCH 7/7] esp: add AMD PCscsi emulation (PCI SCSI adapter)

[Hervé Poussineau]

Michael S. Tsirkin a écrit :
> On Sun, Jun 03, 2012 at 12:38:09PM +0200, Hervé Poussineau wrote:
>> The PCI version is supported in lots of Operating Systems,
>> and has been successfully tested on:
>> - MS DOS 6.22 with MS Windows 3.11
>> - MS Windows 98 SE
>> - MS Windows NT 4.0
>>
>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

...

>> +
>> +static void pci_handle_abort(PCIESPState *pci, uint32_t val)
>> +{
>> +    trace_esp_pci_dma_abort(val);
>> +    if (pci->esp.current_req) {
>> +        scsi_req_cancel(pci->esp.current_req);
>> +    }
>> +}
>> +
> 
> It is better to prefix all global scope symbols with
> esp_ consistently. Reduces the chance of a conflict.

All these functions are local to the file. I'll change that to 
pci_esp_... like other PCI-related functions in this file.

> 
>> +static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint32_t val)
>> +{
>> +    trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
>> +    switch (saddr) {
>> +    case DMA_CMD:
>> +        pci->dma_regs[saddr] = val;
>> +        switch (val & DMA_CMD_MASK) {
>> +        case 0x0: /* IDLE */
>> +            trace_esp_pci_dma_idle(val);
>> +            break;
>> +        case 0x1: /* BLAST */
>> +            pci_handle_blast(pci, val);
> 
> fall-through intentional?

Not at all. Thanks.

Hervé

Re: [Qemu-devel] [PATCH 7/7] esp: add AMD PCscsi emulation (PCI SCSI adapter)

[Michael S. Tsirkin]

On Sun, Jun 03, 2012 at 01:17:57PM +0200, Hervé Poussineau wrote:
> >It is better to prefix all global scope symbols with
> >esp_ consistently. Reduces the chance of a conflict.
> 
> All these functions are local to the file. I'll change that to
> pci_esp_... like other PCI-related functions in this file.

esp_pci would be clearer and preferable.

> >
> >>+static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint32_t val)
> >>+{
> >>+    trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
> >>+    switch (saddr) {
> >>+    case DMA_CMD:
> >>+        pci->dma_regs[saddr] = val;
> >>+        switch (val & DMA_CMD_MASK) {
> >>+        case 0x0: /* IDLE */
> >>+            trace_esp_pci_dma_idle(val);
> >>+            break;
> >>+        case 0x1: /* BLAST */
> >>+            pci_handle_blast(pci, val);
> >
> >fall-through intentional?
> 
> Not at all. Thanks.
> 
> Hervé

[Qemu-devel] [PATCH 0/7] esp: add AMD PCscsi emulation

[Hervé Poussineau]

This patchset adds a PCI connection to the 53c9x emulation already
present in QEMU.  The emulated card is the AMD PCscsi adapter,
and has been tested on multiple Microsoft operating systems.

Changes v1 -> v2:
- use qemu_log_mask(LOG_UNIMP, ...) instead of error_report()
- use prefix esp_pci_* for functions related to PCI emulation
- add missing break
- fix DMA start for Select and Transfer Information commands

Hervé Poussineau (9):
  esp: execute select commands immediately when it is a non-dma command
  esp: delay Transfer Information command if dma is not enabled
  esp: implement Disable selection command
  esp: implement Reset ATN command
  esp: support future change of chip_id
  esp: use hba_private field instead of a complex cast
  esp: split esp code into generic chip emulation and sysbus layer
  esp: use trace framework instead of stderr output
  esp: add AMD PCscsi emulation (PCI SCSI adapter)

 default-configs/i386-softmmu.mak |    1 +
 hw/esp.c                         |  544 ++++++++++++++++++++++++++++++++------
 hw/pci_ids.h                     |    1 +
 trace-events                     |   17 ++
 4 files changed, 481 insertions(+), 82 deletions(-)

-- 
1.7.10