From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc1sI-0004M2-Ej for qemu-devel@nongnu.org; Tue, 05 Jun 2012 18:05:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sc1sG-00014u-NZ for qemu-devel@nongnu.org; Tue, 05 Jun 2012 18:05:14 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:32775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc1sG-00014S-Fe for qemu-devel@nongnu.org; Tue, 05 Jun 2012 18:05:12 -0400 Received: by dadv2 with SMTP id v2so8527920dad.4 for ; Tue, 05 Jun 2012 15:05:10 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 6 Jun 2012 00:04:50 +0200 Message-Id: <1338933895-20677-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1338933895-20677-1-git-send-email-pbonzini@redhat.com> References: <1338933895-20677-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v3 2/7] savevm: flush after saving vm state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com Writing vm state uses bdrv_pwrite, so it will automatically get flushes in writethrough mode. But doing a flush at the end in writeback mode is probably a good idea anyway. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index 2d18bab..2b6833d 100644 --- a/savevm.c +++ b/savevm.c @@ -400,7 +400,7 @@ static int block_get_buffer(void *opaque, uint8_t *buf, int64_t pos, int size) static int bdrv_fclose(void *opaque) { - return 0; + return bdrv_flush(opaque); } static QEMUFile *qemu_fopen_bdrv(BlockDriverState *bs, int is_writable) -- 1.7.10.1