Re: [Qemu-devel] [PATCH 02/31] dt: add helpers for 2, 3 and 4 cell adds

[Peter Crosthwaite <peter.crosthwaite@petalogix.com>]

On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> We have device tree helpers that allow us to create single cell (u32)
> wide properties. However, when creating properties that contain an array of
> cells, we need to jump through hoops, manually passing in an array with
> converted endianness.
> 
> To ease the pain of this a bit, create helpers for the most common array
> sizes, namely 2, 3 and 4 cells wide properties.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  device_tree.c |   30 ++++++++++++++++++++++++++++++
>  device_tree.h |    9 +++++++++
>  2 files changed, 39 insertions(+), 0 deletions(-)
> 
> diff --git a/device_tree.c b/device_tree.c
> index 94a239e..b1dff4f 100644
> --- a/device_tree.c
> +++ b/device_tree.c
> @@ -117,6 +117,36 @@ int qemu_devtree_setprop_cell(void *fdt, const char *node_path,
>      return r;
>  }
>  
> +int qemu_devtree_setprop_cell2(void *fdt, const char *node_path,
> +                               const char *property, uint32_t val,
> +                               uint32_t val2)
> +{
> +    uint32_t tmp[] = { cpu_to_be32(val),
> +                       cpu_to_be32(val2) };
> +    return qemu_devtree_setprop(fdt, node_path, property, tmp, sizeof(tmp));
> +}
> +
> +int qemu_devtree_setprop_cell3(void *fdt, const char *node_path,
> +                               const char *property, uint32_t val,
> +                               uint32_t val2, uint32_t val3)
> +{
> +    uint32_t tmp[] = { cpu_to_be32(val),
> +                       cpu_to_be32(val2),
> +                       cpu_to_be32(val3) };
> +    return qemu_devtree_setprop(fdt, node_path, property, tmp, sizeof(tmp));
> +}
> +
> +int qemu_devtree_setprop_cell4(void *fdt, const char *node_path,
> +                               const char *property, uint32_t val,
> +                               uint32_t val2, uint32_t val3, uint32_t val4)
> +{
> +    uint32_t tmp[] = { cpu_to_be32(val),
> +                       cpu_to_be32(val2),
> +                       cpu_to_be32(val3),
> +                       cpu_to_be32(val4) };
> +    return qemu_devtree_setprop(fdt, node_path, property, tmp, sizeof(tmp));
> +}
> +

Cant this be generalised to the n case rather than having functional
replication for 2/3/4 word props?

+int qemu_devtree_setprop_celln(void *fdt, const char *node_path,
+                               const char *property, uint32_t *vals, int n)


>  int qemu_devtree_setprop_string(void *fdt, const char *node_path,
>                                  const char *property, const char *string)
>  {
> diff --git a/device_tree.h b/device_tree.h
> index 4378685..9db7f86 100644
> --- a/device_tree.h
> +++ b/device_tree.h
> @@ -20,6 +20,15 @@ int qemu_devtree_setprop(void *fdt, const char *node_path,
>                           const char *property, void *val_array, int size);
>  int qemu_devtree_setprop_cell(void *fdt, const char *node_path,
>                                const char *property, uint32_t val);
> +int qemu_devtree_setprop_cell2(void *fdt, const char *node_path,
> +                               const char *property, uint32_t val,
> +                               uint32_t val2);
> +int qemu_devtree_setprop_cell3(void *fdt, const char *node_path,
> +                               const char *property, uint32_t val,
> +                               uint32_t val2, uint32_t val3);
> +int qemu_devtree_setprop_cell4(void *fdt, const char *node_path,
> +                               const char *property, uint32_t val,
> +                               uint32_t val2, uint32_t val3, uint32_t val4);
>  int qemu_devtree_setprop_string(void *fdt, const char *node_path,
>                                  const char *property, const char *string);
>  int qemu_devtree_nop_node(void *fdt, const char *node_path);