From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc8SP-0004F7-6r for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:06:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sc8SK-00079E-M8 for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:06:54 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:34146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc8SK-000792-Fu for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:06:52 -0400 Received: by pbbro12 with SMTP id ro12so9140696pbb.4 for ; Tue, 05 Jun 2012 22:06:50 -0700 (PDT) From: Peter Crosthwaite In-Reply-To: <1338940402-28502-4-git-send-email-agraf@suse.de> References: <1338940402-28502-1-git-send-email-agraf@suse.de> <1338940402-28502-4-git-send-email-agraf@suse.de> Content-Type: text/plain; charset="UTF-8" Date: Wed, 06 Jun 2012 15:06:49 +1000 Message-ID: <1338959209.15420.8.camel@PetaLogix-ws2> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/31] dt: add helper for phandle references List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc Mailing List , "qemu-devel@nongnu.org Developers" On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote: > Phandles are the fancy device tree name for "pointer to another node". > To create a phandle property, we most likely want to reference to the > node we're pointing to by its path. So create a helper that allows > us to do so. > > Signed-off-by: Alexander Graf > --- > device_tree.c | 7 +++++++ > device_tree.h | 2 ++ > 2 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/device_tree.c b/device_tree.c > index b1dff4f..8e9262c 100644 > --- a/device_tree.c > +++ b/device_tree.c > @@ -162,6 +162,13 @@ int qemu_devtree_setprop_string(void *fdt, const char *node_path, > return r; > } > > +int qemu_devtree_setprop_phandle(void *fdt, const char *node_path, > + const char *property, const char *string) "string" is a bit of a misnomer for this argument, considering its a node_path. Maybe "target", or "target_node_path" > +{ > + uint32_t phandle = fdt_get_phandle(fdt, findnode_nofail(fdt, string)); > + return qemu_devtree_setprop_cell(fdt, node_path, property, phandle); > +} > + > int qemu_devtree_nop_node(void *fdt, const char *node_path) > { > int r; > diff --git a/device_tree.h b/device_tree.h > index 9db7f86..2e87c58 100644 > --- a/device_tree.h > +++ b/device_tree.h > @@ -31,6 +31,8 @@ int qemu_devtree_setprop_cell4(void *fdt, const char *node_path, > uint32_t val2, uint32_t val3, uint32_t val4); > int qemu_devtree_setprop_string(void *fdt, const char *node_path, > const char *property, const char *string); > +int qemu_devtree_setprop_phandle(void *fdt, const char *node_path, > + const char *property, const char *string); > int qemu_devtree_nop_node(void *fdt, const char *node_path); > int qemu_devtree_add_subnode(void *fdt, const char *name); >