qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc Mailing List <qemu-ppc@nongnu.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 08/31] dt: add helper for 64bit cell adds
Date: Wed, 06 Jun 2012 15:20:32 +1000	[thread overview]
Message-ID: <1338960032.15420.19.camel@PetaLogix-ws2> (raw)
In-Reply-To: <1338940402-28502-9-git-send-email-agraf@suse.de>

On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> Some times in the device tree, we find an array of 2 u32 cells that
> really are a single u64 value. This patch adds a helper to make the
> creation of these easy.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Reviewed-by: Peter Crosthwaite <peter.crosthwaite@petalogix.com>

> ---
> 
> v1 -> v2:
> 
>   - rename cell64 -> u64
> ---
>  device_tree.c |    7 +++++++
>  device_tree.h |    2 ++
>  2 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/device_tree.c b/device_tree.c
> index 317bdd0..644d766 100644
> --- a/device_tree.c
> +++ b/device_tree.c
> @@ -154,6 +154,13 @@ int qemu_devtree_setprop_cell(void *fdt, const char *node_path,
>      return r;
>  }
>  
> +int qemu_devtree_setprop_u64(void *fdt, const char *node_path,
> +                             const char *property, uint64_t val)
> +{
> +    val = cpu_to_be64(val);
> +    return qemu_devtree_setprop(fdt, node_path, property, &val, sizeof(val));
> +}
> +
>  int qemu_devtree_setprop_cell2(void *fdt, const char *node_path,
>                                 const char *property, uint32_t val,
>                                 uint32_t val2)
> diff --git a/device_tree.h b/device_tree.h
> index f37a4da..39dd259 100644
> --- a/device_tree.h
> +++ b/device_tree.h
> @@ -21,6 +21,8 @@ int qemu_devtree_setprop(void *fdt, const char *node_path,
>                           const char *property, void *val_array, int size);
>  int qemu_devtree_setprop_cell(void *fdt, const char *node_path,
>                                const char *property, uint32_t val);
> +int qemu_devtree_setprop_u64(void *fdt, const char *node_path,
> +                             const char *property, uint64_t val);
>  int qemu_devtree_setprop_cell2(void *fdt, const char *node_path,
>                                 const char *property, uint32_t val,
>                                 uint32_t val2);

  reply	other threads:[~2012-06-06  5:20 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05 23:52 [Qemu-devel] [PATCH 00/31] PPC: mpc8544ds: Create device tree dynamically Alexander Graf
2012-06-05 23:52 ` [Qemu-devel] [PATCH 01/31] dt: allow add_subnode to create root subnodes Alexander Graf
2012-06-06  5:30   ` Peter Crosthwaite
2012-06-05 23:52 ` [Qemu-devel] [PATCH 02/31] dt: add helpers for 2, 3 and 4 cell adds Alexander Graf
2012-06-06  5:01   ` Peter Crosthwaite
2012-06-06 15:55     ` Alexander Graf
2012-06-06 21:52       ` Scott Wood
2012-06-06 23:45         ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-06-07 11:27           ` Alexander Graf
2012-06-07 12:13             ` David Gibson
2012-06-08 13:00               ` Alexander Graf
2012-06-08 14:15                 ` David Gibson
2012-06-05 23:52 ` [Qemu-devel] [PATCH 03/31] dt: add helper for phandle references Alexander Graf
2012-06-06  5:06   ` Peter Crosthwaite
2012-06-05 23:52 ` [Qemu-devel] [PATCH 04/31] dt: temporarily disable subtree creation failure check Alexander Graf
2012-06-06  5:32   ` Peter Crosthwaite
2012-06-06 15:58     ` Alexander Graf
2012-06-05 23:52 ` [Qemu-devel] [PATCH 05/31] dt: add helper for phandle enumeration Alexander Graf
2012-06-06  5:11   ` Peter Crosthwaite
2012-06-06 15:58     ` Alexander Graf
2012-06-07  0:28       ` Peter Crosthwaite
2012-06-08 12:46         ` Alexander Graf
2012-06-09  1:02           ` Peter Crosthwaite
2012-06-19 14:03             ` Alexander Graf
2012-06-05 23:52 ` [Qemu-devel] [PATCH 06/31] dt: add helper for empty dt creation Alexander Graf
2012-06-06  5:34   ` Peter Crosthwaite
2012-06-05 23:52 ` [Qemu-devel] [PATCH 07/31] dt: add helper for phandle allocation Alexander Graf
2012-06-06  5:18   ` Peter Crosthwaite
2012-06-06 16:00     ` Alexander Graf
2012-06-06 16:55       ` Scott Wood
2012-06-07  0:15         ` Peter Crosthwaite
2012-06-07  0:31           ` Scott Wood
2012-06-05 23:52 ` [Qemu-devel] [PATCH 08/31] dt: add helper for 64bit cell adds Alexander Graf
2012-06-06  5:20   ` Peter Crosthwaite [this message]
2012-06-05 23:53 ` [Qemu-devel] [PATCH 09/31] PPC: e500: require libfdt Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 10/31] PPC: e500: dt: create memory node dynamically Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 11/31] PPC: e500: dt: create /cpus " Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 12/31] PPC: e500: dt: create /hypervisor " Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 13/31] PPC: e500: dt: create / " Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 14/31] PPC: e500: dt: create /chosen " Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 15/31] PPC: e500: dt: create /soc8544 " Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 16/31] PPC: e500: dt: create serial nodes dynamically Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 17/31] PPC: e500: dt: create mpic node dynamically Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 18/31] PPC: e500: dt: create global-utils " Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 19/31] PPC: e500: dt: create pci " Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 20/31] PPC: e500: dt: start with empty device tree Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 21/31] dt: Add -machine dumpdtb option to dump the current dtb Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 22/31] PPC: e500: dt: use 64bit cell helper Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 23/31] PPC: e500: dt: use target_phys_addr_t for ramsize Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 24/31] PPC: e500: enable manual loading of dtb blob Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 25/31] Revert "dt: temporarily disable subtree creation failure check" Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 26/31] PPC: e500: Use new MPIC dt format Alexander Graf
2012-06-07 21:08   ` [Qemu-devel] [Qemu-ppc] " Blue Swirl
2012-06-05 23:53 ` [Qemu-devel] [PATCH 27/31] PPC: e500: Use new SOC " Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 28/31] PPC: e500: Define addresses as always 64bit Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 29/31] PPC: e500: Extend address/size of / to 64bit Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 30/31] dt: Add global option to set phandle start offset Alexander Graf
2012-06-05 23:53 ` [Qemu-devel] [PATCH 31/31] PPC: e500: Refactor serial dt generation Alexander Graf
2012-06-07 21:09 ` [Qemu-devel] [PATCH 00/31] PPC: mpc8544ds: Create device tree dynamically Blue Swirl
2012-06-19 12:54   ` Alexander Graf
2012-06-19 18:39     ` Blue Swirl
2012-06-19 19:14       ` Alexander Graf
  -- strict thread matches above, loose matches on Subject: below --
2012-06-19 19:14 Alexander Graf
2012-06-19 19:15 ` [Qemu-devel] [PATCH 08/31] dt: add helper for 64bit cell adds Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338960032.15420.19.camel@PetaLogix-ws2 \
    --to=peter.crosthwaite@petalogix.com \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).