From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 2/2] qmp: do not include monitor.h from qapi-types-core.h
Date: Wed, 6 Jun 2012 08:09:23 +0200 [thread overview]
Message-ID: <1338962963-21277-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1338962963-21277-1-git-send-email-pbonzini@redhat.com>
The comment is stale, monitor.h is not needed anymore (only qerror.h
is, because it contains the schema for errors).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hmp.c | 1 +
qapi/qapi-types-core.h | 4 +---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hmp.c b/hmp.c
index bb0952e..7be673e 100644
--- a/hmp.c
+++ b/hmp.c
@@ -16,6 +16,7 @@
#include "hmp.h"
#include "qemu-timer.h"
#include "qmp-commands.h"
+#include "monitor.h"
static void hmp_handle_error(Monitor *mon, Error **errp)
{
diff --git a/qapi/qapi-types-core.h b/qapi/qapi-types-core.h
index 27e6be0..f781fc3 100644
--- a/qapi/qapi-types-core.h
+++ b/qapi/qapi-types-core.h
@@ -16,8 +16,6 @@
#include "qemu-common.h"
#include "error.h"
-
-/* FIXME this is temporary until we remove middle mode */
-#include "monitor.h"
+#include "qerror.h"
#endif
--
1.7.10.1
next prev parent reply other threads:[~2012-06-06 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 6:08 [Qemu-devel] [PATCH 0/2] Clean up includes of monitor.h Paolo Bonzini
2012-06-06 6:09 ` [Qemu-devel] [PATCH 1/2] kvm: add missing include files Paolo Bonzini
2012-06-06 6:09 ` Paolo Bonzini [this message]
2012-06-06 17:44 ` [Qemu-devel] [PATCH 0/2] Clean up includes of monitor.h Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338962963-21277-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).