From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScOND-0005Na-4O for qemu-devel@nongnu.org; Wed, 06 Jun 2012 18:06:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScONB-0000ZT-I0 for qemu-devel@nongnu.org; Wed, 06 Jun 2012 18:06:38 -0400 Received: from 50-56-35-84.static.cloud-ips.com ([50.56.35.84]:41968 helo=mail.hallyn.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScONB-0000ZF-Dl for qemu-devel@nongnu.org; Wed, 06 Jun 2012 18:06:37 -0400 From: Serge Hallyn References: <20120224195143.GA16353@vostro.hallyn.com> <4FCF855D.8050208@weilnetz.de> <20120606174936.GA9515@sergelap> <4FCFC8AC.6020300@weilnetz.de> In-Reply-To: <4FCFC8AC.6020300@weilnetz.de> Content-Type: text/plain; charset=utf-8 Content-ID: <1339018243.1461.1.camel@Nokia-N900-51-1> Date: Wed, 06 Jun 2012 16:30:45 -0500 Message-Id: <1339018245.1461.2.camel@Nokia-N900-51-1> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile Reply-To: Serge Hallyn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , Serge Hallyn Cc: aneesh.kumar@linux.vnet.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, Stefano Stabellini ----- Original message ----- > Am 06.06.2012 19:49, schrieb Serge Hallyn: > > Quoting Stefan Weil (sw@weilnetz.de): > > > The patch will fix the compiler error messages, but will the > > > resulting code work? Maybe it has runtime dependencies > > > (Linux kernel?) which should be checked at runtime. > > >=20 > > > Would an enhanced test in configure be a better solution? > > > It could disable VirtFS automatically if the definitions > > > are missing. > > >=20 > > > On Ubuntu Lenny, there is no definition for AT_EMPTY_PATH, > > (Debian Lenny I presume) >=20 > Sorry, my mistake. I meant Ubuntu Lucid. >=20 > > True, the flag is newer than I thought.=C2=A0 How could the configur= e option > > be enhanced?=C2=A0 Could we simply grep for it in > > /usr/include/linux/fcntl.h, set an option saying it exists, then stil= l > > do the #ifndef in hw/9pfs/virtio-9p-handle.c? > >=20 > > (The problem is that the glibc and linux headers are currently not > > compatible...=C2=A0 a separate problem, yes, but one I can't current= ly > > overcome AFAIK) >=20 > I'd use virtio-9p-handle only if AT_EMPTY_PATH is defined without > requiring a hack like using linux/fcntl.h. >=20 > configure can check that. Should I send a patch which does this check? That'd be great, please do - thanks! -Serge