qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] Clean up includes of monitor.h
Date: Thu,  7 Jun 2012 04:02:19 +0200	[thread overview]
Message-ID: <1339034542-8960-1-git-send-email-pbonzini@redhat.com> (raw)

There is no reason why QAPI clients should use monitor.h at all,
qerror.h suffices.

qmp-commands.h uses the Monitor typedef, but it is only included
from files that already get the typedef from qemu-common.h.

v1->v2: rebase to queue/qmp

Paolo Bonzini (3):
  kvm: add missing include files
  qmp: include monitor.h when needed
  qmp: do not include monitor.h from qapi-types-core.h

 hmp.c                  |    1 +
 kvm-all.c              |    2 ++
 net/tap.c              |    1 +
 qapi/qapi-types-core.h |    4 +---
 4 files changed, 5 insertions(+), 3 deletions(-)

-- 
1.7.10.1

             reply	other threads:[~2012-06-07  2:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-07  2:02 Paolo Bonzini [this message]
2012-06-07  2:02 ` [Qemu-devel] [PATCH v2 1/3] kvm: add missing include files Paolo Bonzini
2012-06-07  2:02 ` [Qemu-devel] [PATCH v2 2/3] qmp: include monitor.h when needed Paolo Bonzini
2012-06-07  2:02 ` [Qemu-devel] [PATCH v2 3/3] qmp: do not include monitor.h from qapi-types-core.h Paolo Bonzini
2012-06-07  4:55   ` Anthony Liguori
2012-06-07  5:35     ` Paolo Bonzini
2012-06-12 23:06     ` Andreas Färber
2012-06-12 18:57 ` [Qemu-devel] [PATCH v2 0/3] Clean up includes of monitor.h Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339034542-8960-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).