From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Scw2D-0001MH-UF for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:03:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Scw28-0007zO-BH for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:03:13 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:34593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Scw28-0007yB-2g for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:03:08 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Jun 2012 11:03:03 +0100 Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q58A2JQc2433178 for ; Fri, 8 Jun 2012 11:02:19 +0100 Received: from d06av10.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q589n7iP028818 for ; Fri, 8 Jun 2012 05:49:07 -0400 From: Stefan Hajnoczi Date: Fri, 8 Jun 2012 11:02:07 +0100 Message-Id: <1339149729-26331-2-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1339149729-26331-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1339149729-26331-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 1/3] Clarify comments of tb_invalidate_phys_[page_]range List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , qemu-devel@nongnu.org, Stefan Hajnoczi From: Jan Kiszka They could suggest that all TBs of the page containing the range would be invalidated. Signed-off-by: Jan Kiszka Signed-off-by: Stefan Hajnoczi --- exec.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/exec.c b/exec.c index 1b65859..eacaf3c 100644 --- a/exec.c +++ b/exec.c @@ -1076,11 +1076,11 @@ TranslationBlock *tb_gen_code(CPUArchState *env, } /* - * invalidate all TBs which intersect with the target physical pages - * starting in range [start;end[. NOTE: start and end may refer to - * different physical pages. 'is_cpu_write_access' should be true if called - * from a real cpu write access: the virtual CPU will exit the current - * TB if code is modified inside this TB. + * Invalidate all TBs which intersect with the target physical address range + * [start;end[. NOTE: start and end may refer to *different* physical pages. + * 'is_cpu_write_access' should be true if called from a real cpu write + * access: the virtual CPU will exit the current TB if code is modified inside + * this TB. */ void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end, int is_cpu_write_access) @@ -1092,11 +1092,13 @@ void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end, } } -/* invalidate all TBs which intersect with the target physical page - starting in range [start;end[. NOTE: start and end must refer to - the same physical page. 'is_cpu_write_access' should be true if called - from a real cpu write access: the virtual CPU will exit the current - TB if code is modified inside this TB. */ +/* + * Invalidate all TBs which intersect with the target physical address range + * [start;end[. NOTE: start and end must refer to the *same* physical page. + * 'is_cpu_write_access' should be true if called from a real cpu write + * access: the virtual CPU will exit the current TB if code is modified inside + * this TB. + */ void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end, int is_cpu_write_access) { -- 1.7.10