From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 4/8] qapi: Add String visitor coverage to serialization unit tests
Date: Fri, 8 Jun 2012 17:35:09 +0200 [thread overview]
Message-ID: <1339169713-31205-5-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1339169713-31205-1-git-send-email-afaerber@suse.de>
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
tests/test-visitor-serialization.c | 40 ++++++++++++++++++++++++++++++++++++
1 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/tests/test-visitor-serialization.c b/tests/test-visitor-serialization.c
index 6ef57d0..b8ad16f 100644
--- a/tests/test-visitor-serialization.c
+++ b/tests/test-visitor-serialization.c
@@ -19,6 +19,8 @@
#include "qemu-objects.h"
#include "qapi/qmp-input-visitor.h"
#include "qapi/qmp-output-visitor.h"
+#include "qapi/string-input-visitor.h"
+#include "qapi/string-output-visitor.h"
typedef struct PrimitiveType {
union {
@@ -666,6 +668,37 @@ static void qmp_cleanup(void *datap)
qmp_input_visitor_cleanup(d->qiv);
}
+typedef struct StringSerializeData {
+ StringOutputVisitor *sov;
+ StringInputVisitor *siv;
+} StringSerializeData;
+
+static void string_serialize(void *native_in, void **datap,
+ VisitorFunc visit, Error **errp)
+{
+ StringSerializeData *d = g_malloc0(sizeof(*d));
+
+ d->sov = string_output_visitor_new();
+ visit(string_output_get_visitor(d->sov), &native_in, errp);
+ *datap = d;
+}
+
+static void string_deserialize(void **native_out, void *datap,
+ VisitorFunc visit, Error **errp)
+{
+ StringSerializeData *d = datap;
+
+ d->siv = string_input_visitor_new(string_output_get_string(d->sov));
+ visit(string_input_get_visitor(d->siv), native_out, errp);
+}
+
+static void string_cleanup(void *datap)
+{
+ StringSerializeData *d = datap;
+ string_output_visitor_cleanup(d->sov);
+ string_input_visitor_cleanup(d->siv);
+}
+
/* visitor registration, test harness */
/* note: to function interchangeably as a serialization mechanism your
@@ -680,6 +713,13 @@ static const SerializeOps visitors[] = {
.cleanup = qmp_cleanup,
.caps = VCAP_PRIMITIVES | VCAP_STRUCTURES | VCAP_LISTS
},
+ {
+ .type = "String",
+ .serialize = string_serialize,
+ .deserialize = string_deserialize,
+ .cleanup = string_cleanup,
+ .caps = VCAP_PRIMITIVES
+ },
{ NULL }
};
--
1.7.7
next prev parent reply other threads:[~2012-06-08 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 15:35 [Qemu-devel] [PULL] qom-next queue, first batch: fixed-width visitors Andreas Färber
2012-06-08 15:35 ` [Qemu-devel] [PATCH 1/8] qapi: Add Visitor interfaces for uint*_t and int*_t Andreas Färber
2012-06-09 15:03 ` Laszlo Ersek
2012-06-09 15:16 ` Andreas Färber
2012-06-09 15:33 ` Laszlo Ersek
2012-06-09 20:33 ` Michael Roth
2012-06-08 15:35 ` [Qemu-devel] [PATCH 2/8] qapi: Unit tests for visitor-based serialization Andreas Färber
2012-06-08 15:35 ` [Qemu-devel] [PATCH 3/8] qapi: String visitor, use %f representation for floats Andreas Färber
2012-06-08 15:35 ` Andreas Färber [this message]
2012-06-08 15:35 ` [Qemu-devel] [PATCH 5/8] qdev: Use int32_t container for devfn property Andreas Färber
2012-06-08 15:35 ` [Qemu-devel] [PATCH 6/8] qdev: Switch property accessors to fixed-width visitor interfaces Andreas Färber
2012-06-08 15:35 ` [Qemu-devel] [PATCH 7/8] qdev: Remove PropertyInfo range checking Andreas Färber
2012-06-08 15:35 ` [Qemu-devel] [PATCH 8/8] target-i386: Use uint32 visitor for [x]level properties Andreas Färber
2012-06-08 21:39 ` [Qemu-devel] [PULL] qom-next queue, first batch: fixed-width visitors Andreas Färber
2012-06-11 17:19 ` Luiz Capitulino
2012-06-11 18:28 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339169713-31205-5-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).