From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55627)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Sd5QB-0005pY-Pw
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 16:04:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Sd5Q7-0007Nd-DB
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 16:04:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9101)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1Sd5Q7-0007NZ-4o
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 16:04:31 -0400
Message-ID: <1339185867.26976.127.camel@ul30vt>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Fri, 08 Jun 2012 14:04:27 -0600
In-Reply-To: <4FCDDEDF.6070308@siemens.com>
References: <4FCCCC81.4090504@siemens.com>
	<20120605102020.GE19834@redhat.com> <4FCDDEDF.6070308@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] msix: Drop unused msix_bar_size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

On Tue, 2012-06-05 at 12:26 +0200, Jan Kiszka wrote:
> On 2012-06-05 12:20, Michael S. Tsirkin wrote:
> > On Mon, Jun 04, 2012 at 04:56:01PM +0200, Jan Kiszka wrote:
> >> No user in sight.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > Just to note, currently (since the memory API changes) all users assume
> > a single 4K page for MSI-X, we will need some API to remove that
> > assumption.
> > Still the patch is fine.
> 
> Yep, I have a patch for this here (I think I posted an earlier version
> before). It's required to do device assignment using the MSI layer.

Would you mind sending a pointer or reposting, I can't find it.  Trying
to switch vfio to not require existing capabilities checks I was
reminded of the horror of msix_init().  We need a pretty good overhaul
here to be able to allow the flexibility of defining where both the
vector table a pba live to make it more compatible with real devices.  I
honestly don't see the benefit of allowing msix_init() the ability to
resize a BAR to give itself room.  There are only two other users
currently, ivshmem and virtio, both of which allocate a BAR exclusively
for MSI-X.  Thanks,

Alex