qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Peter A. G. Crosthwaite" <peter.crothwaite@petalogix.com>,
	"Alexander Graf" <agraf@suse.de>,
	"Blue Swirl" <blauwirbel@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build
Date: Sat,  9 Jun 2012 03:54:28 +0200	[thread overview]
Message-ID: <1339206871-4706-1-git-send-email-afaerber@suse.de> (raw)

Hello Edgar and Peter,

With the Makefile refactoring applied now, here's the Makefile improvements
for MicroBlaze I mentioned.

All Xilinx devices that are used for more than one softmmu are compiled once
in libhw32. Actually some also in libhw64 due to ppc440 being compiled into
ppc64, but we can fix that in a second step via Alex' ppc-next, we're already
down from thrice to twice.

The middle patch is extracted from Blue's logging refactoring.

Please test and apply. Your s3adp1800 and virtel_ml507 test images complain
both with and without patches about not finding "eth0". Selftest completes ok
except for not finding /usr/bin/sha1test on ppc440.

xilinx_ethlite.c uses tswap32(). Have you ever tested this device to work on
microblazeel? I wonder if we could change the device from DEVICE_NATIVE_ENDIAN
to DEVICE_BIG_ENDIAN and in place of tswap32() use a bswap32() conditional on
HOST_WORDS_BIGENDIAN so that it becomes independent of the target, too?

Instead of adding random devices to hw/microblaze/Makefile.objs in new series,
they should be added to hw/Makefile.objs with appropriate CONFIG_* options set
in default-configs/microblaze[el]-softmmu.mak as demonstrated here, easy to do
and also ensures that the appropriate poisoning is applied.

Regards,
Andreas

Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Cc: Peter A. G. Crosthwaite <peter.crothwaite@petalogix.com>
Cc: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>

Andreas Färber (3):
  hw/xilinx_*: Share Xilinx devices between ppc and microblaze
  qemu-log: Allow usage in libhw
  xilinx_axi*: Share devices between microblaze and microblazeel

 default-configs/microblaze-softmmu.mak   |    2 ++
 default-configs/microblazeel-softmmu.mak |    2 ++
 default-configs/ppc-softmmu.mak          |    1 +
 default-configs/ppc64-softmmu.mak        |    1 +
 default-configs/ppcemb-softmmu.mak       |    1 +
 hw/Makefile.objs                         |    7 +++++++
 hw/microblaze/Makefile.objs              |    5 -----
 hw/ppc/Makefile.objs                     |    3 ---
 qemu-log.h                               |    2 ++
 9 files changed, 16 insertions(+), 8 deletions(-)

-- 
1.7.7

             reply	other threads:[~2012-06-09  1:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-09  1:54 Andreas Färber [this message]
2012-06-09  1:54 ` [Qemu-devel] [PATCH 1/3] hw/xilinx_*: Share Xilinx devices between ppc and microblaze Andreas Färber
2012-06-09  2:15   ` Peter Crosthwaite
2012-06-09  2:31     ` Andreas Färber
2012-06-09  2:36       ` Peter Crosthwaite
2012-06-09  1:54 ` [Qemu-devel] [PATCH 2/3] qemu-log: Allow usage in libhw Andreas Färber
2012-06-09  1:54 ` [Qemu-devel] [PATCH 3/3] xilinx_axi*: Share devices between microblaze and microblazeel Andreas Färber
2012-06-09  2:16   ` Peter Crosthwaite
2012-06-09  2:06 ` [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build Peter Crosthwaite
2012-06-09 15:20 ` Edgar E. Iglesias
2012-06-09 15:31   ` Andreas Färber
2012-06-09 21:23     ` Edgar E. Iglesias
2012-06-15 11:13 ` Edgar E. Iglesias
2012-06-15 14:52   ` Andreas Färber
2012-06-16  4:15     ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339206871-4706-1-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=blauwirbel@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crothwaite@petalogix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).