From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdy2r-0004OJ-Gj for qemu-devel@nongnu.org; Mon, 11 Jun 2012 02:24:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sdy2p-0005C5-E1 for qemu-devel@nongnu.org; Mon, 11 Jun 2012 02:24:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdy2p-0005Bk-6Q for qemu-devel@nongnu.org; Mon, 11 Jun 2012 02:24:07 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5B6O5DH003823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Jun 2012 02:24:05 -0400 From: Alon Levy Date: Mon, 11 Jun 2012 09:24:00 +0300 Message-Id: <1339395841-31413-3-git-send-email-alevy@redhat.com> In-Reply-To: <1339395841-31413-1-git-send-email-alevy@redhat.com> References: <1339395841-31413-1-git-send-email-alevy@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] qxl: refuse to create primary larger then fb size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com Signed-off-by: Alon Levy --- hw/qxl.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index a9b4fd1..6596856 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1204,6 +1204,16 @@ static void qxl_create_guest_primary(PCIQXLDevice *qxl, int loadvm, { QXLDevSurfaceCreate surface; QXLSurfaceCreate *sc = &qxl->guest_primary.surface; + int size; + int requested_height = le32_to_cpu(sc->height); + int requested_stride = le32_to_cpu(sc->stride); + + size = abs(requested_stride) * requested_height; + if (size > qxl->fb_size) { + qxl_set_guest_bug(qxl, "%s: requested primary larger then framebuffer" + " size", __func__); + return; + } if (qxl->mode == QXL_MODE_NATIVE) { qxl_set_guest_bug(qxl, "%s: nop since already in QXL_MODE_NATIVE", -- 1.7.10.1