qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alon Levy <alevy@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 01/10] ui/spice-display.c: add missing initialization for valgrind
Date: Tue, 12 Jun 2012 09:51:05 +0200	[thread overview]
Message-ID: <1339487474-8481-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1339487474-8481-1-git-send-email-kraxel@redhat.com>

From: Alon Levy <alevy@redhat.com>

We can't initialize QXLDevSurfaceCreate field by field because it has a
pa hole, and so 4 bytes remain uninitialized when building on x86-64, so
just memset.

Signed-off-by: Alon Levy <alevy@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/spice-display.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/ui/spice-display.c b/ui/spice-display.c
index 5418eb3..3e8f0b3 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -244,6 +244,8 @@ void qemu_spice_create_host_primary(SimpleSpiceDisplay *ssd)
 {
     QXLDevSurfaceCreate surface;
 
+    memset(&surface, 0, sizeof(surface));
+
     dprint(1, "%s: %dx%d\n", __FUNCTION__,
            ds_get_width(ssd->ds), ds_get_height(ssd->ds));
 
-- 
1.7.1

  reply	other threads:[~2012-06-12  7:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12  7:51 [Qemu-devel] [PATCH 00/10] spice/vga: make vga memory size configurable Gerd Hoffmann
2012-06-12  7:51 ` Gerd Hoffmann [this message]
2012-06-12  7:51 ` [Qemu-devel] [PATCH 02/10] hw/qxl: s/qxl_guest_bug/qxl_set_guest_bug/ Gerd Hoffmann
2012-06-12  7:51 ` [Qemu-devel] [PATCH 03/10] qxl: stop dirty loging when not in vga mode Gerd Hoffmann
2012-06-12  7:51 ` [Qemu-devel] [PATCH 04/10] hw/qxl: ignore guest from guestbug until reset Gerd Hoffmann
2012-06-12  7:51 ` [Qemu-devel] [PATCH 05/10] qxl: reset current_async on qxl_soft_reset Gerd Hoffmann
2012-06-12  7:51 ` [Qemu-devel] [PATCH 06/10] vga: raise xres+yres limits Gerd Hoffmann
2012-06-12  7:51 ` [Qemu-devel] [PATCH 07/10] vga: make vram size configurable Gerd Hoffmann
2012-06-12  7:51 ` [Qemu-devel] [PATCH 08/10] qxl: add vgamem_size_mb and vgamem_size Gerd Hoffmann
2012-06-12  9:37   ` Daniel P. Berrange
2012-06-12 11:55     ` Gerd Hoffmann
2012-06-13 11:48       ` Alon Levy
2012-06-14 13:44   ` Alon Levy
2012-06-12  7:51 ` [Qemu-devel] [PATCH 09/10] add pc-1.2 Gerd Hoffmann
2012-06-12  7:51 ` [Qemu-devel] [PATCH 10/10] vga: raise default vgamem size Gerd Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2012-06-22  9:25 [Qemu-devel] [PULL 00/10] spice patch queue: qxl & vga bits Gerd Hoffmann
2012-06-22  9:25 ` [Qemu-devel] [PATCH 01/10] ui/spice-display.c: add missing initialization for valgrind Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339487474-8481-2-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).