From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert
Date: Wed, 13 Jun 2012 22:36:27 +0800 [thread overview]
Message-ID: <1339598189-17933-4-git-send-email-wdongxu@linux.vnet.ibm.com> (raw)
In-Reply-To: <1339598189-17933-1-git-send-email-wdongxu@linux.vnet.ibm.com>
add-cow file can't live alone, must together will image_file and backing_file.
If we implement qemu-img convert operation for add-cow file format, we must
create image_file and backing_file manually, that will be confused for users,
so we just ignore add-cow format while doing converting.
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
---
qemu-img.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index c8a70ff..0bce61c 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -756,6 +756,12 @@ static int img_convert(int argc, char **argv)
}
}
+ if (strcmp(out_fmt, "add-cow") == 0) {
+ error_report("Convert operation does not support %s format.", out_fmt);
+ ret = -1;
+ goto out;
+ }
+
/* Find driver and parse its options */
drv = bdrv_find_format(out_fmt);
if (!drv) {
--
1.7.1
next prev parent reply other threads:[~2012-06-13 14:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 14:36 [Qemu-devel] [PATCH 1/6 v10] docs: spec for add-cow file format Dong Xu Wang
2012-06-13 14:36 ` [Qemu-devel] [PATCH 2/6] block: make some functions public Dong Xu Wang
2012-06-13 14:36 ` [Qemu-devel] [PATCH 3/6] add-cow file format Dong Xu Wang
2012-06-14 11:13 ` Paolo Bonzini
2012-06-18 2:08 ` Dong Xu Wang
2012-06-13 14:36 ` Dong Xu Wang [this message]
2012-06-14 10:51 ` [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert Kevin Wolf
2012-06-14 14:06 ` Dong Xu Wang
2012-06-14 14:11 ` Kevin Wolf
2012-06-14 14:17 ` Dong Xu Wang
2012-06-14 14:24 ` Kevin Wolf
2012-06-14 14:26 ` Dong Xu Wang
2012-06-13 14:36 ` [Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev Dong Xu Wang
2012-06-14 10:59 ` Kevin Wolf
2012-06-14 11:18 ` Paolo Bonzini
2012-06-14 11:33 ` Kevin Wolf
2012-07-19 2:20 ` Dong Xu Wang
2012-07-19 8:17 ` Kevin Wolf
2012-07-19 13:18 ` Luiz Capitulino
2012-07-19 9:57 ` Stefan Hajnoczi
2012-06-13 14:36 ` [Qemu-devel] [PATCH 6/6] add-cow: support qemu-iotests Dong Xu Wang
2012-06-13 15:10 ` [Qemu-devel] [PATCH 1/6 v10] docs: spec for add-cow file format Eric Blake
2012-06-14 3:06 ` Dong Xu Wang
2012-06-14 10:47 ` Kevin Wolf
2012-06-18 2:08 ` Dong Xu Wang
2012-06-18 15:33 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339598189-17933-4-git-send-email-wdongxu@linux.vnet.ibm.com \
--to=wdongxu@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).