qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Makefile: Fix linker failure for vscclient
@ 2012-06-13 20:45 Stefan Weil
  2012-06-15 19:07 ` Blue Swirl
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-06-13 20:45 UTC (permalink / raw)
  To: Anthony Liguori; +Cc: Stefan Weil, qemu-devel

When QEMU was built with the simple trace backend, linking failed:

  LINK  vscclient
oslib-posix.o: In function `trace_qemu_memalign':
qemu/bin/debug/x86/./trace.h:31: undefined reference to `trace3'
oslib-posix.o: In function `trace_qemu_vmalloc':
qemu/bin/debug/x86/./trace.h:35: undefined reference to `trace2'
oslib-posix.o: In function `trace_qemu_vfree':
qemu/bin/debug/x86/./trace.h:39: undefined reference to `trace1'
collect2: error: ld returned 1 exit status
make: *** [vscclient] Fehler 1

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 32550cb..9b6c9f7 100644
--- a/Makefile
+++ b/Makefile
@@ -148,7 +148,8 @@ install-libcacard: libcacard.la
 	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C libcacard V="$(V)" TARGET_DIR="$*/" install-libcacard,)
 endif
 
-vscclient$(EXESUF): $(libcacard-y) $(oslib-obj-y) qemu-timer-common.o libcacard/vscclient.o
+vscclient$(EXESUF): $(libcacard-y) $(oslib-obj-y) qemu-timer-common.o \
+		    libcacard/vscclient.o $(trace-obj-y)
 	$(call quiet-command,$(CC) -o $@ $^ $(libcacard_libs) $(LIBS),"  LINK  $@")
 
 ######################################################################
-- 
1.7.10

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] Makefile: Fix linker failure for vscclient
  2012-06-13 20:45 [Qemu-devel] [PATCH] Makefile: Fix linker failure for vscclient Stefan Weil
@ 2012-06-15 19:07 ` Blue Swirl
  0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2012-06-15 19:07 UTC (permalink / raw)
  To: Stefan Weil; +Cc: Anthony Liguori, qemu-devel

On Wed, Jun 13, 2012 at 8:45 PM, Stefan Weil <sw@weilnetz.de> wrote:
> When QEMU was built with the simple trace backend, linking failed:
>
>  LINK  vscclient
> oslib-posix.o: In function `trace_qemu_memalign':
> qemu/bin/debug/x86/./trace.h:31: undefined reference to `trace3'
> oslib-posix.o: In function `trace_qemu_vmalloc':
> qemu/bin/debug/x86/./trace.h:35: undefined reference to `trace2'
> oslib-posix.o: In function `trace_qemu_vfree':
> qemu/bin/debug/x86/./trace.h:39: undefined reference to `trace1'
> collect2: error: ld returned 1 exit status
> make: *** [vscclient] Fehler 1

This will be fixed with my gcov patch set.

>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  Makefile |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 32550cb..9b6c9f7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -148,7 +148,8 @@ install-libcacard: libcacard.la
>        $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C libcacard V="$(V)" TARGET_DIR="$*/" install-libcacard,)
>  endif
>
> -vscclient$(EXESUF): $(libcacard-y) $(oslib-obj-y) qemu-timer-common.o libcacard/vscclient.o
> +vscclient$(EXESUF): $(libcacard-y) $(oslib-obj-y) qemu-timer-common.o \
> +                   libcacard/vscclient.o $(trace-obj-y)
>        $(call quiet-command,$(CC) -o $@ $^ $(libcacard_libs) $(LIBS),"  LINK  $@")
>
>  ######################################################################
> --
> 1.7.10
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-15 19:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-13 20:45 [Qemu-devel] [PATCH] Makefile: Fix linker failure for vscclient Stefan Weil
2012-06-15 19:07 ` Blue Swirl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).