From: Guan Xuetao <gxt@mprc.pku.edu.cn>
To: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kernel can access user space
Date: Mon, 18 Jun 2012 10:03:33 +0800 [thread overview]
Message-ID: <1339985013.1674.0.camel@ubuntu.ubuntu-domain> (raw)
In-Reply-To: <20120615100111.GA98347@cs.nctu.edu.tw>
On Fri, 2012-06-15 at 18:01 +0800, 陳韋任 (Wei-Ren Chen) wrote:
> Hi Guan,
>
> > /* These instructions trap after executing, so defer them until after the
> > conditional executions state has been updated. */
> > @@ -1551,12 +1558,12 @@ static void do_misc(CPUUniCore32State *env, DisasContext *s, uint32_t insn)
> > /* load/store I_offset and R_offset */
> > static void do_ldst_ir(CPUUniCore32State *env, DisasContext *s, uint32_t insn)
> > {
> > - unsigned int i;
> > + unsigned int mmuindex;
> ^^^^^^^^
> I would suggest you to rename it to mmu_idx or something like that. :)
>
> Regards,
> chenwj
>
Done, thx.
Regards
Guan Xuetao
next prev parent reply other threads:[~2012-06-18 2:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 9:47 [Qemu-devel] [PATCHv2 00/13] unicore32: add softmmu support and puv3 machine Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 01/13] unicore32-softmmu: Add unicore32-softmmu build support Guan Xuetao
2012-06-15 10:28 ` Paolo Bonzini
2012-06-15 12:46 ` Andreas Färber
2012-06-15 13:13 ` Paolo Bonzini
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 02/13] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support Guan Xuetao
2012-06-15 11:13 ` Andreas Färber
2012-06-18 2:08 ` Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 03/13] unicore32-softmmu: Make UniCore32 cpuid & exceptions correct and runable Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 04/13] unicore32-softmmu: Implement softmmu specific functions Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kernel can access user space Guan Xuetao
2012-06-15 10:01 ` 陳韋任 (Wei-Ren Chen)
2012-06-18 2:03 ` Guan Xuetao [this message]
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 06/13] unicore32-softmmu: Add puv3 soc/board support Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 07/13] unicore32-softmmu: Add puv3 interrupt support Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 08/13] unicore32-softmmu: Add puv3 ostimer support Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 09/13] unicore32-softmmu: Add puv3 gpio support Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 10/13] unicore32-softmmu: Add puv3 pm support Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 11/13] unicore32-softmmu: Add puv3 dma support Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 12/13] unicore32-softmmu: Add ps2 support Guan Xuetao
2012-06-15 9:47 ` [Qemu-devel] [PATCHv2 13/13] unicore32-softmmu: Add maintainer information for UniCore32 machine Guan Xuetao
2012-06-15 10:17 ` [Qemu-devel] [PATCHv2 00/13] unicore32: add softmmu support and puv3 machine 陳韋任 (Wei-Ren Chen)
2012-06-18 2:05 ` Guan Xuetao
2012-06-18 6:58 ` 陳韋任 (Wei-Ren Chen)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339985013.1674.0.camel@ubuntu.ubuntu-domain \
--to=gxt@mprc.pku.edu.cn \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=chenwj@iis.sinica.edu.tw \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).