From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SgRKt-0002iY-2r for qemu-devel@nongnu.org; Sun, 17 Jun 2012 22:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SgRKr-0006Lh-Gx for qemu-devel@nongnu.org; Sun, 17 Jun 2012 22:04:58 -0400 Received: from mprc.pku.edu.cn ([162.105.203.9]:53443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SgRKq-0006LK-PC for qemu-devel@nongnu.org; Sun, 17 Jun 2012 22:04:57 -0400 Message-ID: <1339985013.1674.0.camel@ubuntu.ubuntu-domain> From: Guan Xuetao Date: Mon, 18 Jun 2012 10:03:33 +0800 In-Reply-To: <20120615100111.GA98347@cs.nctu.edu.tw> References: <56a7fc70336de91d650005bd77a3c7044feb0831.1339753406.git.gxt@mprc.pku.edu.cn> <20120615100111.GA98347@cs.nctu.edu.tw> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kernel can access user space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "=?UTF-8?Q?=E9=99=B3=E9=9F=8B=E4=BB=BB?= (Wei-Ren Chen)" Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, afaerber@suse.de On Fri, 2012-06-15 at 18:01 +0800, =E9=99=B3=E9=9F=8B=E4=BB=BB (Wei-Ren C= hen) wrote: > Hi Guan, >=20 > > /* These instructions trap after executing, so defer them until afte= r the > > conditional executions state has been updated. */ > > @@ -1551,12 +1558,12 @@ static void do_misc(CPUUniCore32State *env, D= isasContext *s, uint32_t insn) > > /* load/store I_offset and R_offset */ > > static void do_ldst_ir(CPUUniCore32State *env, DisasContext *s, uint= 32_t insn) > > { > > - unsigned int i; > > + unsigned int mmuindex; > ^^^^^^^^ > I would suggest you to rename it to mmu_idx or something like that. = :) >=20 > Regards, > chenwj >=20 Done, thx. Regards Guan Xuetao