From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btbgy-0007cr-Hb for qemu-devel@nongnu.org; Mon, 10 Oct 2016 10:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btbgt-0007Bz-6u for qemu-devel@nongnu.org; Mon, 10 Oct 2016 10:36:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btbgs-0007Bs-W8 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 10:36:31 -0400 References: <1476100224-19760-1-git-send-email-imbrenda@linux.vnet.ibm.com> <1476100224-19760-2-git-send-email-imbrenda@linux.vnet.ibm.com> From: Paolo Bonzini Message-ID: <133a4c1d-d029-0bc2-d538-4e5c8e3dac1b@redhat.com> Date: Mon, 10 Oct 2016 16:36:26 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 1/2] gdbstub: Fix single-step List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: Claudio Imbrenda , qemu-devel@nongnu.org On 10/10/2016 14:51, Christian Borntraeger wrote: > On 10/10/2016 01:50 PM, Claudio Imbrenda wrote: >> Commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 introduced a bug that >> causes single-step in the gdbstub to not work, at least in kvm. CPUs >> that are supposed to single-step will instead run normally. >> >> This small patch fixes the problem. (tested on s390x) >> >> Signed-off-by: Claudio Imbrenda >> --- >> kvm-all.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kvm-all.c b/kvm-all.c >> index efb5fe3..46b8dcd 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -2237,6 +2237,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap) >> data.dbg.control |= KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTEP; >> } >> kvm_arch_update_guest_debug(cpu, &data.dbg); >> + data.cpu = cpu; >> >> run_on_cpu(cpu, kvm_invoke_set_guest_debug, &data); >> return data.err; >> > > Adding Alex and Paolo to cc. The patch works but it also makes sense to use the new CPUState* argument of kvm_invoke_set_guest_debug. This way the kvm_set_guest_debug_data struct doesn't need the "cpu" field anymore. Paolo