From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"Anthony Liguori" <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PATCH 10/22] qdev: Push "type" property up to Object
Date: Mon, 18 Jun 2012 15:59:02 +0200 [thread overview]
Message-ID: <1340027954-19045-11-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1340027954-19045-1-git-send-email-afaerber@suse.de>
From: Paolo Bonzini <pbonzini@redhat.com>
Now that Object is a type, add an instance_init function and push
the "type" property from qdev to there.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/qdev.c | 6 ------
qom/object.c | 11 +++++++++++
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 6a8f6bd..a9a9f89 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -515,11 +515,6 @@ char* qdev_get_fw_dev_path(DeviceState *dev)
return strdup(path);
}
-static char *qdev_get_type(Object *obj, Error **errp)
-{
- return g_strdup(object_get_typename(obj));
-}
-
/**
* Legacy property handling
*/
@@ -638,7 +633,6 @@ static void device_initfn(Object *obj)
qdev_property_add_static(dev, prop, NULL);
}
- object_property_add_str(OBJECT(dev), "type", qdev_get_type, NULL, NULL);
qdev_prop_set_defaults(dev, qdev_get_props(dev));
}
diff --git a/qom/object.c b/qom/object.c
index cec2d40..d5c6ff7 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1231,6 +1231,16 @@ void object_property_add_str(Object *obj, const char *name,
prop, errp);
}
+static char *qdev_get_type(Object *obj, Error **errp)
+{
+ return g_strdup(object_get_typename(obj));
+}
+
+static void object_instance_init(Object *obj)
+{
+ object_property_add_str(obj, "type", qdev_get_type, NULL, NULL);
+}
+
static void register_types(void)
{
static TypeInfo interface_info = {
@@ -1242,6 +1252,7 @@ static void register_types(void)
static TypeInfo object_info = {
.name = TYPE_OBJECT,
.instance_size = sizeof(Object),
+ .instance_init = object_instance_init,
.abstract = true,
};
--
1.7.7
next prev parent reply other threads:[~2012-06-18 14:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 13:58 [Qemu-devel] [PULL] qom-next queue, second batch: QBus, API additions and cleanups Andreas Färber
2012-06-18 13:58 ` [Qemu-devel] [PATCH 01/22] qom: Add object_class_get_parent() Andreas Färber
2012-06-18 13:58 ` [Qemu-devel] [PATCH 02/22] qom: Introduce object_property_is_{child, link}() Andreas Färber
2012-06-18 13:58 ` [Qemu-devel] [PATCH 03/22] qom: Add object_child_foreach() Andreas Färber
2012-06-18 13:58 ` [Qemu-devel] [PATCH 04/22] qom: Add class_base_init Andreas Färber
2012-06-18 13:58 ` [Qemu-devel] [PATCH 05/22] qom: Make Object a type Andreas Färber
2012-06-18 13:58 ` [Qemu-devel] [PATCH 06/22] qom: Drop type_register_static_alias() macro Andreas Färber
2012-06-18 13:58 ` [Qemu-devel] [PATCH 07/22] qom: Assert that public types have a non-NULL parent field Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 08/22] m48t59: Rename "type" property to "model" Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 09/22] arm_l2x0: Rename "type" property to "cache-type" Andreas Färber
2012-06-18 13:59 ` Andreas Färber [this message]
2012-06-18 13:59 ` [Qemu-devel] [PATCH 11/22] qdev: Move bus properties to a separate global Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 12/22] qdev: Move bus properties to abstract superclasses Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 13/22] qdev: Clean up global properties Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 14/22] qdev: Remove qdev_prop_set_defaults Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 15/22] qdev: Use wrapper for qdev_get_path Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 16/22] qdev: Move SysBus initialization to sysbus.c Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 17/22] qdev: Convert busses to QEMU Object Model Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 18/22] qdev: Connect busses with their parent devices Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 19/22] qbus: Make child devices links Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 20/22] qbus: Initialize in standard way Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 21/22] qdev: Remove qdev_prop_exists() Andreas Färber
2012-06-18 13:59 ` [Qemu-devel] [PATCH 22/22] qom: Push error reporting to object_property_find() Andreas Färber
2012-06-20 13:09 ` [Qemu-devel] [PULL] qom-next queue, second batch: QBus, API additions and cleanups Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340027954-19045-11-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).