From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShABQ-00030L-KN for qemu-devel@nongnu.org; Tue, 19 Jun 2012 21:58:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShABO-00011Y-VR for qemu-devel@nongnu.org; Tue, 19 Jun 2012 21:58:12 -0400 Received: from mprc.pku.edu.cn ([162.105.203.9]:56149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShABO-00010m-49 for qemu-devel@nongnu.org; Tue, 19 Jun 2012 21:58:10 -0400 Message-ID: <1340157413.1748.28.camel@ubuntu.ubuntu-domain> From: Guan Xuetao Date: Wed, 20 Jun 2012 09:56:53 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, chenwj@iis.sinica.edu.tw, afaerber@suse.de On Mon, 2012-06-18 at 20:02 +0000, Blue Swirl wrote: [snip] > > diff --git a/hw/puv3.h b/hw/puv3.h > > new file mode 100644 > > index 0000000..bcfc978 > > --- /dev/null > > +++ b/hw/puv3.h > > @@ -0,0 +1,49 @@ > > +/* > > + * Misc PKUnity SoC declarations > > + * > > + * Copyright (C) 2010-2012 Guan Xuetao > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation, or any later version. > > + * See the COPYING file in the top-level directory. > > + */ > > +#ifndef __PUV3_H__ > > Use of leading underscores is reserved to Posix, please use for > example HW_PUV3_H. Ok, I will change it. Perhaps I'm wrong, but IMHO, leading underscores are used pervasively for headers protection and low-level definitions. Guan Xuetao