From: Guan Xuetao <gxt@mprc.pku.edu.cn>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, chenwj@iis.sinica.edu.tw, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support
Date: Wed, 20 Jun 2012 10:00:22 +0800 [thread overview]
Message-ID: <1340157622.1748.31.camel@ubuntu.ubuntu-domain> (raw)
In-Reply-To: <CAAu8pHtdKx7_mOimwFrLVXW9V_hFN95SfjirhUsoZPmMx3M39g@mail.gmail.com>
On Mon, 2012-06-18 at 20:05 +0000, Blue Swirl wrote:
[snip]
> > +static void puv3_pm_write(void *opaque, target_phys_addr_t offset,
> > + uint64_t value, unsigned size)
> > +{
> > + PUV3PMState *s = (PUV3PMState *) opaque;
> > +
> > + switch (offset) {
> > + case 0x0:
> > + s->reg_PMCR = value;
>
> Missing 'break' or a comment about fall through.
Yes, 'break' is missed here.
Thanks ever so much.
Guan Xuetao
next prev parent reply other threads:[~2012-06-20 2:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 9:24 [Qemu-devel] [PATCHv3 00/14] unicore32: add softmmu support and puv3 machine Guan Xuetao
2012-06-18 9:24 ` [Qemu-devel] [PATCHv3 01/14] unicore32-softmmu: Add unicore32-softmmu build support Guan Xuetao
2012-06-18 9:24 ` [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support Guan Xuetao
2012-06-18 19:51 ` Blue Swirl
2012-06-20 1:40 ` Guan Xuetao
2012-06-20 8:08 ` 陳韋任 (Wei-Ren Chen)
2012-06-21 17:44 ` Blue Swirl
2012-06-25 3:23 ` guanxuetao
2012-06-18 9:24 ` [Qemu-devel] [PATCHv3 03/14] unicore32-softmmu: Make UniCore32 cpuid & exceptions correct and runable Guan Xuetao
2012-06-18 9:24 ` [Qemu-devel] [PATCHv3 04/14] target-unicore32: Drop UC32_CPUID macros Guan Xuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 05/14] unicore32-softmmu: Implement softmmu specific functions Guan Xuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 06/14] unicore32-softmmu: Make sure that kernel can access user space Guan Xuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support Guan Xuetao
2012-06-18 20:02 ` Blue Swirl
2012-06-20 1:56 ` Guan Xuetao
2012-06-21 17:15 ` Blue Swirl
2012-06-25 3:14 ` guanxuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 08/14] unicore32-softmmu: Add puv3 interrupt support Guan Xuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 09/14] unicore32-softmmu: Add puv3 ostimer support Guan Xuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 10/14] unicore32-softmmu: Add puv3 gpio support Guan Xuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support Guan Xuetao
2012-06-18 20:05 ` Blue Swirl
2012-06-20 2:00 ` Guan Xuetao [this message]
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 12/14] unicore32-softmmu: Add puv3 dma support Guan Xuetao
2012-06-18 19:59 ` Blue Swirl
2012-06-20 2:10 ` Guan Xuetao
2012-06-21 17:20 ` Blue Swirl
2012-06-25 3:18 ` guanxuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 13/14] unicore32-softmmu: Add ps2 support Guan Xuetao
2012-06-18 9:25 ` [Qemu-devel] [PATCHv3 14/14] unicore32-softmmu: Add maintainer information for UniCore32 machine Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340157622.1748.31.camel@ubuntu.ubuntu-domain \
--to=gxt@mprc.pku.edu.cn \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=chenwj@iis.sinica.edu.tw \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).