From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36291)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gxt@mprc.pku.edu.cn>) id 1ShAEk-0004Ik-0c
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 22:01:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gxt@mprc.pku.edu.cn>) id 1ShAEi-0002IZ-FB
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 22:01:37 -0400
Received: from mprc.pku.edu.cn ([162.105.203.9]:54035)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gxt@mprc.pku.edu.cn>) id 1ShAEh-0002IK-Mu
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 22:01:36 -0400
Message-ID: <1340157622.1748.31.camel@ubuntu.ubuntu-domain>
From: Guan Xuetao <gxt@mprc.pku.edu.cn>
Date: Wed, 20 Jun 2012 10:00:22 +0800
In-Reply-To: <CAAu8pHtdKx7_mOimwFrLVXW9V_hFN95SfjirhUsoZPmMx3M39g@mail.gmail.com>
References: <cover.1340010818.git.gxt@mprc.pku.edu.cn>
	<7e50d5a67915d77eecf86ae77ceb2ac5091cc661.1340010818.git.gxt@mprc.pku.edu.cn>
	<CAAu8pHtdKx7_mOimwFrLVXW9V_hFN95SfjirhUsoZPmMx3M39g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm
	support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, chenwj@iis.sinica.edu.tw, afaerber@suse.de

On Mon, 2012-06-18 at 20:05 +0000, Blue Swirl wrote:
[snip]
> > +static void puv3_pm_write(void *opaque, target_phys_addr_t offset,
> > +        uint64_t value, unsigned size)
> > +{
> > +    PUV3PMState *s = (PUV3PMState *) opaque;
> > +
> > +    switch (offset) {
> > +    case 0x0:
> > +        s->reg_PMCR = value;
> 
> Missing 'break' or a comment about fall through.
Yes, 'break' is missed here.
Thanks ever so much.

Guan Xuetao