* [Qemu-devel] [PATCH] tci: Support INDEX_op_bswap64_i64
@ 2012-06-20 16:07 Stefan Weil
2012-06-22 9:09 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-06-20 16:07 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
Running the Windows 7 (64 bit) boot process needs INDEX_op_bswap64_i64.
It was already implemented, but untested. Remove the TODO() statement.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tci.c b/tci.c
index e40c080..01d365a 100644
--- a/tci.c
+++ b/tci.c
@@ -1036,7 +1036,6 @@ tcg_target_ulong tcg_qemu_tb_exec(CPUArchState *cpustate, uint8_t *tb_ptr)
#endif
#if TCG_TARGET_HAS_bswap64_i64
case INDEX_op_bswap64_i64:
- TODO();
t0 = *tb_ptr++;
t1 = tci_read_r64(&tb_ptr);
tci_write_reg64(t0, bswap64(t1));
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] tci: Support INDEX_op_bswap64_i64
2012-06-20 16:07 [Qemu-devel] [PATCH] tci: Support INDEX_op_bswap64_i64 Stefan Weil
@ 2012-06-22 9:09 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-06-22 9:09 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Wed, Jun 20, 2012 at 06:07:24PM +0200, Stefan Weil wrote:
> Running the Windows 7 (64 bit) boot process needs INDEX_op_bswap64_i64.
> It was already implemented, but untested. Remove the TODO() statement.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> tci.c | 1 -
> 1 file changed, 1 deletion(-)
If you weren't TCI maintainer I would ask for this patch to go through
your tree because I don't touch TCG and this is declaring an operation
supported, which the maintainer needs to be okay with. Anyway, this is
fine since it's coming from you.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-22 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-20 16:07 [Qemu-devel] [PATCH] tci: Support INDEX_op_bswap64_i64 Stefan Weil
2012-06-22 9:09 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).