From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShXTU-0006Gh-FV for qemu-devel@nongnu.org; Wed, 20 Jun 2012 22:50:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShXTS-00073X-DQ for qemu-devel@nongnu.org; Wed, 20 Jun 2012 22:50:23 -0400 Received: from gate.crashing.org ([63.228.1.57]:57648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShXTS-00073B-4o for qemu-devel@nongnu.org; Wed, 20 Jun 2012 22:50:22 -0400 Message-ID: <1340247010.28143.222.camel@pasglop> From: Benjamin Herrenschmidt Date: Thu, 21 Jun 2012 12:50:10 +1000 In-Reply-To: <20120621014514.GC12749@truffala.fritz.box> References: <1340087992-2399-1-git-send-email-benh@kernel.crashing.org> <1340087992-2399-3-git-send-email-benh@kernel.crashing.org> <4FE23D61.3030000@codemonkey.ws> <20120621014514.GC12749@truffala.fritz.box> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-devel@nongnu.org, Anthony Liguori On Thu, 2012-06-21 at 11:45 +1000, David Gibson wrote: > > Why should this be in the core API? Shouldn't this be a helper on > > top of the DMA API? > > Well, I was hoping to avoid having to allocate a temporary buffer of > zeroes, which is necessary to do this in terms of the existing > cpu_physical_memory_write() api. and which I ended up doing anyway in the latest patch following previous reviews where people barfed at having a duplication of the code to access the guest memory :-) Cheers, Ben.