From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShZ0U-0000La-2U for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:28:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShZ0S-00067L-FR for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:28:33 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:39508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShZ0S-00066s-8a for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:28:32 -0400 Received: by dadn2 with SMTP id n2so309311dad.4 for ; Wed, 20 Jun 2012 21:28:28 -0700 (PDT) From: Peter Crosthwaite In-Reply-To: <1340133324-352-3-git-send-email-agraf@suse.de> References: <1340133324-352-1-git-send-email-agraf@suse.de> <1340133324-352-3-git-send-email-agraf@suse.de> Content-Type: text/plain; charset="UTF-8" Date: Thu, 21 Jun 2012 14:28:14 +1000 Message-ID: <1340252894.26508.0.camel@PetaLogix-ws2> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/31] dt: add helpers for multi-cell adds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc Mailing List , qemu-devel qemu-devel On Tue, 2012-06-19 at 21:14 +0200, Alexander Graf wrote: > We have device tree helpers that allow us to create single cell (u32) > wide properties. However, when creating properties that contain an array of > cells, we need to jump through hoops, manually passing in an array with > converted endianness. > > To ease the pain of this, create a generic macro helper that allows us > to pass the cells as arguments. > > Signed-off-by: Alexander Graf Reviewed-by: Peter Crosthwaite > --- > device_tree.h | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/device_tree.h b/device_tree.h > index 4378685..1e671e2 100644 > --- a/device_tree.h > +++ b/device_tree.h > @@ -25,4 +25,16 @@ int qemu_devtree_setprop_string(void *fdt, const char *node_path, > int qemu_devtree_nop_node(void *fdt, const char *node_path); > int qemu_devtree_add_subnode(void *fdt, const char *name); > > +#define qemu_devtree_setprop_cells(fdt, node_path, property, ...) \ > + do { \ > + uint32_t qdt_tmp[] = { __VA_ARGS__ }; \ > + int i; \ > + \ > + for (i = 0; i < ARRAY_SIZE(qdt_tmp); i++) { \ > + qdt_tmp[i] = cpu_to_be32(qdt_tmp[i]); \ > + } \ > + qemu_devtree_setprop(fdt, node_path, property, qdt_tmp, \ > + sizeof(qdt_tmp)); \ > + } while (0) > + > #endif /* __DEVICE_TREE_H__ */