From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShZ2R-0001Fp-Hx for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:30:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShZ2P-00072i-2b for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:30:35 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:44727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShZ2O-00072K-SJ for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:30:33 -0400 Received: by pbbro12 with SMTP id ro12so1582303pbb.4 for ; Wed, 20 Jun 2012 21:30:30 -0700 (PDT) From: Peter Crosthwaite In-Reply-To: <1340133324-352-4-git-send-email-agraf@suse.de> References: <1340133324-352-1-git-send-email-agraf@suse.de> <1340133324-352-4-git-send-email-agraf@suse.de> Content-Type: text/plain; charset="UTF-8" Date: Thu, 21 Jun 2012 14:30:17 +1000 Message-ID: <1340253017.26508.2.camel@PetaLogix-ws2> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/31] dt: add helper for phandle references List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc Mailing List , qemu-devel qemu-devel On Tue, 2012-06-19 at 21:14 +0200, Alexander Graf wrote: > Phandles are the fancy device tree name for "pointer to another node". > To create a phandle property, we most likely want to reference to the > node we're pointing to by its path. So create a helper that allows > us to do so. > > Signed-off-by: Alexander Graf > Reviewed-by: Peter Crosthwaite There are consistency issues with the whole nofail/fail discussion but as Alex pointed out, thats a battle for another day. > --- > > v2 -> v3: > > - rename "string" to target_node_path > --- > device_tree.c | 8 ++++++++ > device_tree.h | 3 +++ > 2 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/device_tree.c b/device_tree.c > index 94a239e..2905f9a 100644 > --- a/device_tree.c > +++ b/device_tree.c > @@ -132,6 +132,14 @@ int qemu_devtree_setprop_string(void *fdt, const char *node_path, > return r; > } > > +int qemu_devtree_setprop_phandle(void *fdt, const char *node_path, > + const char *property, > + const char *target_node_path) > +{ > + uint32_t phandle = fdt_get_phandle(fdt, findnode_nofail(fdt, target_node_path)); > + return qemu_devtree_setprop_cell(fdt, node_path, property, phandle); > +} > + > int qemu_devtree_nop_node(void *fdt, const char *node_path) > { > int r; > diff --git a/device_tree.h b/device_tree.h > index 1e671e2..754bd2b 100644 > --- a/device_tree.h > +++ b/device_tree.h > @@ -22,6 +22,9 @@ int qemu_devtree_setprop_cell(void *fdt, const char *node_path, > const char *property, uint32_t val); > int qemu_devtree_setprop_string(void *fdt, const char *node_path, > const char *property, const char *string); > +int qemu_devtree_setprop_phandle(void *fdt, const char *node_path, > + const char *property, > + const char *target_node_path); > int qemu_devtree_nop_node(void *fdt, const char *node_path); > int qemu_devtree_add_subnode(void *fdt, const char *name); >