From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShZ3Z-0001yt-IF for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShZ3X-0007BB-Lf for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:31:45 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:36490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShZ3X-0007Av-F3 for qemu-devel@nongnu.org; Thu, 21 Jun 2012 00:31:43 -0400 Received: by dadn2 with SMTP id n2so312513dad.4 for ; Wed, 20 Jun 2012 21:31:41 -0700 (PDT) From: Peter Crosthwaite In-Reply-To: <1340133324-352-6-git-send-email-agraf@suse.de> References: <1340133324-352-1-git-send-email-agraf@suse.de> <1340133324-352-6-git-send-email-agraf@suse.de> Content-Type: text/plain; charset="UTF-8" Date: Thu, 21 Jun 2012 14:31:27 +1000 Message-ID: <1340253088.26508.3.camel@PetaLogix-ws2> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/31] dt: add helper for phandle enumeration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc Mailing List , qemu-devel qemu-devel On Tue, 2012-06-19 at 21:14 +0200, Alexander Graf wrote: > This patch adds a helper to search for a node's phandle by its path. This > is especially useful when the phandle is part of an array, not just a single > cell in which case qemu_devtree_setprop_phandle would be the easy choice. > > Signed-off-by: Alexander Graf Reviewed-by: Peter Crosthwaite > --- > device_tree.c | 16 +++++++++++++++- > device_tree.h | 1 + > 2 files changed, 16 insertions(+), 1 deletions(-) > > diff --git a/device_tree.c b/device_tree.c > index 967c97a..2f127b7 100644 > --- a/device_tree.c > +++ b/device_tree.c > @@ -132,11 +132,25 @@ int qemu_devtree_setprop_string(void *fdt, const char *node_path, > return r; > } > > +uint32_t qemu_devtree_get_phandle(void *fdt, const char *path) > +{ > + uint32_t r; > + > + r = fdt_get_phandle(fdt, findnode_nofail(fdt, path)); > + if (r <= 0) { > + fprintf(stderr, "%s: Couldn't get phandle for %s: %s\n", __func__, > + path, fdt_strerror(r)); > + exit(1); > + } > + > + return r; > +} > + > int qemu_devtree_setprop_phandle(void *fdt, const char *node_path, > const char *property, > const char *target_node_path) > { > - uint32_t phandle = fdt_get_phandle(fdt, findnode_nofail(fdt, target_node_path)); > + uint32_t phandle = qemu_devtree_get_phandle(fdt, target_node_path); > return qemu_devtree_setprop_cell(fdt, node_path, property, phandle); > } > > diff --git a/device_tree.h b/device_tree.h > index 754bd2b..36fc9db 100644 > --- a/device_tree.h > +++ b/device_tree.h > @@ -25,6 +25,7 @@ int qemu_devtree_setprop_string(void *fdt, const char *node_path, > int qemu_devtree_setprop_phandle(void *fdt, const char *node_path, > const char *property, > const char *target_node_path); > +uint32_t qemu_devtree_get_phandle(void *fdt, const char *path); > int qemu_devtree_nop_node(void *fdt, const char *node_path); > int qemu_devtree_add_subnode(void *fdt, const char *name); >