From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShhWe-0005ZJ-6S for qemu-devel@nongnu.org; Thu, 21 Jun 2012 09:34:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShhWU-0002EX-Rt for qemu-devel@nongnu.org; Thu, 21 Jun 2012 09:34:19 -0400 From: Alexander Graf Date: Thu, 21 Jun 2012 15:33:58 +0200 Message-Id: <1340285640-28669-10-git-send-email-agraf@suse.de> In-Reply-To: <1340285640-28669-1-git-send-email-agraf@suse.de> References: <1340285640-28669-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH v2 09/11] PPC: Extract SPR dump generation into its own function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel qemu-devel Cc: Caraman Mihai Claudiu-B02008 , qemu-ppc Mailing List This patch moves the debug #ifdef'ed SPR trace generation into its own function, so we can call it from multiple places. Signed-off-by: Alexander Graf --- target-ppc/translate_init.c | 30 ++++++++++++++++++------------ 1 files changed, 18 insertions(+), 12 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index d185aaa..8ff47ae 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -55,28 +55,34 @@ PPC_IRQ_INIT_FN(e500); /* Generic callbacks: * do nothing but store/retrieve spr value */ +static void spr_load_dump_spr(int sprn) +{ +#ifdef PPC_DUMP_SPR_ACCESSES + TCGv_i32 t0 = tcg_const_i32(sprn); + gen_helper_load_dump_spr(t0); + tcg_temp_free_i32(t0); +#endif +} + static void spr_read_generic (void *opaque, int gprn, int sprn) { gen_load_spr(cpu_gpr[gprn], sprn); + spr_load_dump_spr(sprn); +} + +static void spr_store_dump_spr(int sprn) +{ #ifdef PPC_DUMP_SPR_ACCESSES - { - TCGv_i32 t0 = tcg_const_i32(sprn); - gen_helper_load_dump_spr(t0); - tcg_temp_free_i32(t0); - } + TCGv_i32 t0 = tcg_const_i32(sprn); + gen_helper_store_dump_spr(t0); + tcg_temp_free_i32(t0); #endif } static void spr_write_generic (void *opaque, int sprn, int gprn) { gen_store_spr(sprn, cpu_gpr[gprn]); -#ifdef PPC_DUMP_SPR_ACCESSES - { - TCGv_i32 t0 = tcg_const_i32(sprn); - gen_helper_store_dump_spr(t0); - tcg_temp_free_i32(t0); - } -#endif + spr_store_dump_spr(sprn); } #if !defined(CONFIG_USER_ONLY) -- 1.6.0.2