From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39822)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Sht8w-000116-FL
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 21:58:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Sht8u-0002G8-JH
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 21:58:38 -0400
Received: from gate.crashing.org ([63.228.1.57]:36567)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1Sht8u-0002FT-AM
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 21:58:36 -0400
Message-ID: <1340330302.16104.9.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Fri, 22 Jun 2012 11:58:22 +1000
In-Reply-To: <4FE23D1F.3090408@codemonkey.ws>
References: <1340087992-2399-1-git-send-email-benh@kernel.crashing.org>
	<1340087992-2399-2-git-send-email-benh@kernel.crashing.org>
	<4FE23D1F.3090408@codemonkey.ws>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t
	variables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On Wed, 2012-06-20 at 16:14 -0500, Anthony Liguori wrote:

>  diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h
> > new file mode 100644
> > index 0000000..f0ff558
> > --- /dev/null
> > +++ b/hw/qdev-dma.h
> > @@ -0,0 +1,12 @@
> > +/*
> > + * Support for dma_addr_t typed properties
> > + *
> > + * Copyright (C) 2012 David Gibson, IBM Corporation.
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> > + * See the COPYING file in the top-level directory.
> > + */
> > +#include "qdev-addr.h"
> > +
> > +#define DEFINE_PROP_DMAADDR(_n, _s, _f, _d)                               \
> > +    DEFINE_PROP_TADDR(_n, _s, _f, _d)
> 
> Why not make life easy and fix dma_addr_t to 64-bit?

So you guys haven't come to a firm conclusion yet :) I'll leave that as
it is for now, it's trivial anyway. If you want to change target_addr to
be 64-bit that will make dma_addr_t 64-bit too. If you want to make it
64-bit unconditionally, just drop this patch (and change the
definition).

Cheers,
Ben.