From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jason Baron <jbaron@redhat.com>
Cc: mst@redhat.com, jan.kiszka@siemens.com, armbru@redhat.com,
qemu-devel@nongnu.org, yamahata@valinux.co.jp,
alex.williamson@redhat.com, ddutile@redhat.com,
anthony@codemonkey.ws, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 1/3] iommu: remove extra 'typedef struct DMAContext'
Date: Fri, 22 Jun 2012 12:02:35 +1000 [thread overview]
Message-ID: <1340330555.16104.12.camel@pasglop> (raw)
In-Reply-To: <3221578830f39610aa1957704f8cdf66f692cf2d.1340220655.git.jbaron@redhat.com>
On Wed, 2012-06-20 at 16:11 -0400, Jason Baron wrote:
> There are several instances of 'typedef struct DMAContext DMAContext'. Remove them
> all except for the one in qemu-common.h.
Actually, the other way around :-) I'm removing the one in qemu-common.h
in favor of the one in dma.h (at Anthony's request). I'll have a new
series soon...
Cheers,
Ben.
> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
> dma.h | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/dma.h b/dma.h
> index 0d57e50..862373d 100644
> --- a/dma.h
> +++ b/dma.h
> @@ -15,7 +15,6 @@
> #include "block.h"
> #include "kvm.h"
>
> -typedef struct DMAContext DMAContext;
> typedef struct ScatterGatherEntry ScatterGatherEntry;
>
> typedef enum {
> @@ -65,11 +64,11 @@ typedef void DMAUnmapFunc(DMAContext *dma,
> DMADirection dir,
> dma_addr_t access_len);
>
> -typedef struct DMAContext {
> +struct DMAContext {
> DMATranslateFunc *translate;
> DMAMapFunc *map;
> DMAUnmapFunc *unmap;
> -} DMAContext;
> +};
>
> static inline void dma_barrier(DMAContext *dma, DMADirection dir)
> {
next prev parent reply other threads:[~2012-06-22 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 20:11 [Qemu-devel] [PATCH 0/3] iommu: isa dma engine support Jason Baron
2012-06-20 20:11 ` [Qemu-devel] [PATCH 1/3] iommu: remove extra 'typedef struct DMAContext' Jason Baron
2012-06-22 2:02 ` Benjamin Herrenschmidt [this message]
2012-06-20 20:11 ` [Qemu-devel] [PATCH 2/3] iommu: add support for the isa dma engine Jason Baron
2012-06-20 20:11 ` [Qemu-devel] [PATCH 3/3] iommu: add generic mapping support for the isa bus Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340330555.16104.12.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=afaerber@suse.de \
--cc=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=ddutile@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jbaron@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).