From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38041)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1ShtD2-0002mc-Vn
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 22:02:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1ShtD1-0003Xc-70
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 22:02:52 -0400
Received: from gate.crashing.org ([63.228.1.57]:41917)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1ShtD0-0003XT-U7
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 22:02:51 -0400
Message-ID: <1340330555.16104.12.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Fri, 22 Jun 2012 12:02:35 +1000
In-Reply-To: <3221578830f39610aa1957704f8cdf66f692cf2d.1340220655.git.jbaron@redhat.com>
References: <cover.1340220655.git.jbaron@redhat.com>
	<3221578830f39610aa1957704f8cdf66f692cf2d.1340220655.git.jbaron@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] iommu: remove extra 'typedef struct
	DMAContext'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Baron <jbaron@redhat.com>
Cc: mst@redhat.com, jan.kiszka@siemens.com, armbru@redhat.com, qemu-devel@nongnu.org, yamahata@valinux.co.jp, alex.williamson@redhat.com, ddutile@redhat.com, anthony@codemonkey.ws, afaerber@suse.de

On Wed, 2012-06-20 at 16:11 -0400, Jason Baron wrote:
> There are several instances of 'typedef struct DMAContext DMAContext'. Remove them
> all except for the one in qemu-common.h.

Actually, the other way around :-) I'm removing the one in qemu-common.h
in favor of the one in dma.h (at Anthony's request). I'll have a new
series soon...

Cheers,
Ben.

> Signed-off-by: Jason Baron <jbaron@redhat.com>
> ---
>  dma.h |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/dma.h b/dma.h
> index 0d57e50..862373d 100644
> --- a/dma.h
> +++ b/dma.h
> @@ -15,7 +15,6 @@
>  #include "block.h"
>  #include "kvm.h"
>  
> -typedef struct DMAContext DMAContext;
>  typedef struct ScatterGatherEntry ScatterGatherEntry;
>  
>  typedef enum {
> @@ -65,11 +64,11 @@ typedef void DMAUnmapFunc(DMAContext *dma,
>                            DMADirection dir,
>                            dma_addr_t access_len);
>  
> -typedef struct DMAContext {
> +struct DMAContext {
>      DMATranslateFunc *translate;
>      DMAMapFunc *map;
>      DMAUnmapFunc *unmap;
> -} DMAContext;
> +};
>  
>  static inline void dma_barrier(DMAContext *dma, DMADirection dir)
>  {