From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38207)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1ShtDg-0003UX-Ky
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 22:03:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1ShtDe-0003gL-SL
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 22:03:32 -0400
Received: from gate.crashing.org ([63.228.1.57]:41928)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1ShtDe-0003g0-J4
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 22:03:30 -0400
Message-ID: <1340330579.16104.14.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Fri, 22 Jun 2012 12:02:59 +1000
In-Reply-To: <4FE23DBF.9040706@codemonkey.ws>
References: <1340087992-2399-1-git-send-email-benh@kernel.crashing.org>
	<1340087992-2399-4-git-send-email-benh@kernel.crashing.org>
	<4FE23DBF.9040706@codemonkey.ws>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper
	functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>, Richard Henderson <rth@twiddle.net>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On Wed, 2012-06-20 at 16:16 -0500, Anthony Liguori wrote:
> > diff --git a/qemu-common.h b/qemu-common.h
> > index 8f87e41..80026af 100644
> > --- a/qemu-common.h
> > +++ b/qemu-common.h
> > @@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier;
> >   typedef struct VirtIODevice VirtIODevice;
> >   typedef struct QEMUSGList QEMUSGList;
> >   typedef struct SHPCDevice SHPCDevice;
> > +typedef struct DMAContext DMAContext;
> 
> Please don't put this in qemu-common.h.  Stick it in a dma-specific
> header.

Ok so I just removed it from qemu-common.h (it's already in dma.h). It
causes a minor breakage in spapr which is easily fixed by adding the
right include.

I'm building all the targets now and .... it seems to pass.

So it's gone. That does mean that Jason will probably have to change
something to his patches though.

Cheers,
Ben.