From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions
Date: Sun, 24 Jun 2012 17:28:43 +1000 [thread overview]
Message-ID: <1340522923.16104.61.camel@pasglop> (raw)
In-Reply-To: <CAAu8pHurgDkKsEDZKgcsS9TcUQjEvG0s3Gv7xPGy9raHjgNV3Q@mail.gmail.com>
On Sun, 2012-06-24 at 06:03 +0000, Blue Swirl wrote:
> > + * A smarter implementation can be devised if needed to
> > + * use lighter barriers based on the direction of the
> > + * transfer, the DMA context, etc...
> > + */
> > + if (kvm_enabled())
> > + smp_mb();
>
> Missing braces. Please use checkpatch.pl to avoid issues like this.
Ooops, sorry, forgot to make my code butt-ugly ...
I generally run checkpatch lately, for some reason this one went through
the cracks.
Anthony, do you need a repost or can you fix it up ?
Cheers,
Ben.
prev parent reply other threads:[~2012-06-24 7:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 3:29 [Qemu-devel] [PATCH 00/11] iommu series Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 01/11] Better support for dma_addr_t variables Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 02/11] iommu: Add universal DMA helper functions Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 03/11] usb-ohci: Use " Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 04/11] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 05/11] ide/ahci: Use universal DMA helper functions Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 06/11] usb: Convert usb_packet_{map, unmap} to universal DMA helpers Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 07/11] iommu: Introduce IOMMU emulation infrastructure Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 08/11] pseries: Convert sPAPR TCEs to use generic IOMMU infrastructure Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 09/11] iommu: Allow PCI to use " Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 10/11] pseries: Implement IOMMU and DMA for PAPR PCI devices Benjamin Herrenschmidt
2012-06-22 3:29 ` [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions Benjamin Herrenschmidt
2012-06-24 6:03 ` Blue Swirl
2012-06-24 7:28 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340522923.16104.61.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).