From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1SihFd-0004aK-B0
	for qemu-devel@nongnu.org; Sun, 24 Jun 2012 03:28:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1SihFb-00031w-O1
	for qemu-devel@nongnu.org; Sun, 24 Jun 2012 03:28:52 -0400
Received: from gate.crashing.org ([63.228.1.57]:55658)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1SihFb-00031q-FY
	for qemu-devel@nongnu.org; Sun, 24 Jun 2012 03:28:51 -0400
Message-ID: <1340522923.16104.61.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Sun, 24 Jun 2012 17:28:43 +1000
In-Reply-To: <CAAu8pHurgDkKsEDZKgcsS9TcUQjEvG0s3Gv7xPGy9raHjgNV3Q@mail.gmail.com>
References: <1340335785-6451-1-git-send-email-benh@kernel.crashing.org>
	<1340335785-6451-12-git-send-email-benh@kernel.crashing.org>
	<CAAu8pHurgDkKsEDZKgcsS9TcUQjEvG0s3Gv7xPGy9raHjgNV3Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

On Sun, 2012-06-24 at 06:03 +0000, Blue Swirl wrote:
> > +     * A smarter implementation can be devised if needed to
> > +     * use lighter barriers based on the direction of the
> > +     * transfer, the DMA context, etc...
> > +     */
> > +    if (kvm_enabled())
> > +        smp_mb();
> 
> Missing braces. Please use checkpatch.pl to avoid issues like this.

Ooops, sorry, forgot to make my code butt-ugly ...

I generally run checkpatch lately, for some reason this one went through
the cracks.

Anthony, do you need a repost or can you fix it up ?

Cheers,
Ben.