* [Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug
@ 2012-06-24 14:04 Stefan Weil
2012-06-24 16:04 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-06-24 14:04 UTC (permalink / raw)
To: Blue Swirl; +Cc: Stefan Weil, qemu-devel, Alexander Graf
The order of the arguments was wrong (copy+paste error).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
Hi Alex, hi Blue,
there is still one more bug for target-ppc with --enable-debug,
so strictly speaking, the subject is not correct: the patch
fixes the build only partially.
Regards,
Stefan
target-ppc/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 73ee74b..91eb7a0 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -5794,7 +5794,7 @@ static void gen_mtdcrux(DisasContext *ctx)
{
/* NIP cannot be restored if the memory exception comes from an helper */
gen_update_nip(ctx, ctx->nip - 4);
- gen_helper_store_dcr(cpu_gpr[rA(ctx->opcode)], cpu_env,
+ gen_helper_store_dcr(cpu_env, cpu_gpr[rA(ctx->opcode)],
cpu_gpr[rS(ctx->opcode)]);
/* Note: Rc update flag set leads to undefined state of Rc0 */
}
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug
2012-06-24 14:04 [Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug Stefan Weil
@ 2012-06-24 16:04 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2012-06-24 16:04 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel, Alexander Graf
On Sun, Jun 24, 2012 at 2:04 PM, Stefan Weil <sw@weilnetz.de> wrote:
> The order of the arguments was wrong (copy+paste error).
Confirmed, a bug with
d0f1562d6ace0fdb7d2db190dd5a9a2e7492c3b3
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Hi Alex, hi Blue,
>
> there is still one more bug for target-ppc with --enable-debug,
> so strictly speaking, the subject is not correct: the patch
> fixes the build only partially.
>
> Regards,
> Stefan
>
> target-ppc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 73ee74b..91eb7a0 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -5794,7 +5794,7 @@ static void gen_mtdcrux(DisasContext *ctx)
> {
> /* NIP cannot be restored if the memory exception comes from an helper */
> gen_update_nip(ctx, ctx->nip - 4);
> - gen_helper_store_dcr(cpu_gpr[rA(ctx->opcode)], cpu_env,
> + gen_helper_store_dcr(cpu_env, cpu_gpr[rA(ctx->opcode)],
> cpu_gpr[rS(ctx->opcode)]);
> /* Note: Rc update flag set leads to undefined state of Rc0 */
> }
> --
> 1.7.10
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-24 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-24 14:04 [Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug Stefan Weil
2012-06-24 16:04 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).