* Re: [Qemu-devel] Request VFIO inclusion in linux-next [not found] ` <20120627123733.GA5449@mwanda> @ 2012-07-02 3:41 ` Alexey Kardashevskiy 2012-07-02 4:14 ` Alex Williamson 0 siblings, 1 reply; 2+ messages in thread From: Alexey Kardashevskiy @ 2012-07-02 3:41 UTC (permalink / raw) To: Dan Carpenter Cc: Stephen Rothwell, kvm, Greg Kroah-Hartman, Roedel, Joerg, linux-kernel, iommu, qemu-devel, chrisw, Alex Williamson, linux-next, linux-pci, Andrew Morton, Linus Torvalds, David Gibson On 27/06/12 22:37, Dan Carpenter wrote: > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: >> Hi, >> >> VFIO has been kicking around for well over a year now and has been >> posted numerous times for review. The pre-requirements are finally >> available in linux-next (or will be in the 20120626 build) so I'd like >> to request a new branch be included in linux-next with a goal of being >> accepted into v3.6. >> > > Could you run Sparse over the driver? > http://lwn.net/Articles/205624/ > > It reports a bunch of endian problems. Some are definitely bugs > like: > *prev |= cpu_to_le32((u32)epos << 20); What is wrong here? -- Alexey ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] Request VFIO inclusion in linux-next 2012-07-02 3:41 ` [Qemu-devel] Request VFIO inclusion in linux-next Alexey Kardashevskiy @ 2012-07-02 4:14 ` Alex Williamson 0 siblings, 0 replies; 2+ messages in thread From: Alex Williamson @ 2012-07-02 4:14 UTC (permalink / raw) To: Alexey Kardashevskiy Cc: Stephen Rothwell, kvm, Greg Kroah-Hartman, Roedel, Joerg, linux-kernel, qemu-devel, chrisw, iommu, linux-next, linux-pci, Andrew Morton, Linus Torvalds, Dan Carpenter, David Gibson On Mon, 2012-07-02 at 13:41 +1000, Alexey Kardashevskiy wrote: > On 27/06/12 22:37, Dan Carpenter wrote: > > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: > >> Hi, > >> > >> VFIO has been kicking around for well over a year now and has been > >> posted numerous times for review. The pre-requirements are finally > >> available in linux-next (or will be in the 20120626 build) so I'd like > >> to request a new branch be included in linux-next with a goal of being > >> accepted into v3.6. > >> > > > > Could you run Sparse over the driver? > > http://lwn.net/Articles/205624/ > > > > It reports a bunch of endian problems. Some are definitely bugs > > like: > > *prev |= cpu_to_le32((u32)epos << 20); > > > What is wrong here? I believe the only thing wrong here was that prev was a u32* instead of a __le32*. The new version in my tree has much better endian annotation after going through all the sparse errors. The only bug I found in the cleanup was the handling of rbar. It was missing the le32_to_cpu as we copied it out of vconfig. This is later used with pci_user_write_config_dword, so it needs to be in native endian. Thanks, Alex ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-02 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1340686552.1207.128.camel@bling.home>
[not found] ` <20120627123733.GA5449@mwanda>
2012-07-02 3:41 ` [Qemu-devel] Request VFIO inclusion in linux-next Alexey Kardashevskiy
2012-07-02 4:14 ` Alex Williamson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).