qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Christian Hoff <christian.hoff@de.ibm.com>
Subject: [Qemu-devel] [PATCH 10/14] scsi: Fix data length == SCSI_SENSE_BUF_SIZE
Date: Mon,  2 Jul 2012 11:41:23 +0200	[thread overview]
Message-ID: <1341222087-24920-11-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1341222087-24920-1-git-send-email-pbonzini@redhat.com>

From: Christian Hoff <christian.hoff@de.ibm.com>

Fix the edge case where the sense data length is exactly the same
as SCSI_SENSE_BUF_SIZE.
This makes SCSI requests work that use all of the available 95 byte
sense data.

Signed-off-by: Christian Hoff <christian.hoff@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi-bus.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index 14e2f73..4e95eee 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -1389,7 +1389,7 @@ void scsi_req_complete(SCSIRequest *req, int status)
     assert(req->status == -1);
     req->status = status;
 
-    assert(req->sense_len < sizeof(req->sense));
+    assert(req->sense_len <= sizeof(req->sense));
     if (status == GOOD) {
         req->sense_len = 0;
     }
-- 
1.7.10.2

  parent reply	other threads:[~2012-07-02  9:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02  9:41 [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02 Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 01/14] scsi: simplify handling of the VPD page length field Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN Paolo Bonzini
2012-07-03 19:09   ` Blue Swirl
2012-07-04  7:33     ` Paolo Bonzini
2012-07-05 18:03       ` Blue Swirl
2012-07-06  7:05         ` Paolo Bonzini
2012-07-07  7:48           ` Blue Swirl
2012-07-07 12:22             ` Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 03/14] atapi: implement READ DISC INFORMATION Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 04/14] scsi-disk: " Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 05/14] ISCSI: Add SCSI passthrough via scsi-generic to libiscsi Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 06/14] ISCSI: force use of sg for SMC and SSC devices Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 07/14] megasas: Add header file Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 08/14] megasas: LSI Megaraid SAS HBA emulation Paolo Bonzini
2012-07-03 19:09   ` Blue Swirl
2012-07-04  5:52     ` Hannes Reinecke
2012-07-04  7:33       ` Paolo Bonzini
2012-07-05  6:46         ` Hannes Reinecke
2012-07-02  9:41 ` [Qemu-devel] [PATCH 09/14] virtio-scsi: do not crash on adding buffers to the event queue Paolo Bonzini
2012-07-02  9:41 ` Paolo Bonzini [this message]
2012-07-02  9:41 ` [Qemu-devel] [PATCH 11/14] scsi: Fix LOAD_UNLOAD Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 12/14] scsi: Ensure command and transfer lengths are set for all SCSI devices Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 13/14] scsi: Add basic support for SCSI media changer commands Paolo Bonzini
2012-07-02  9:41 ` [Qemu-devel] [PATCH 14/14] scsi: Fix transfer length for READ POSITION commands Paolo Bonzini
2012-07-09 16:48 ` [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02 Anthony Liguori
2012-07-09 23:09   ` Alexander Graf
2012-07-09 23:19     ` Anthony Liguori
2012-07-10  5:57       ` Hannes Reinecke
2012-07-10  7:06         ` Paolo Bonzini
2012-07-10 12:52         ` Anthony Liguori
2012-07-10 13:01           ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341222087-24920-11-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=christian.hoff@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).