qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, rusty@rustcorp.com.au, anthony@codemonkey.ws,
	kvm@vger.kernel.org, mst@redhat.com
Subject: [Qemu-devel] [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements
Date: Tue,  3 Jul 2012 15:20:40 +0200	[thread overview]
Message-ID: <1341321642-24598-1-git-send-email-pbonzini@redhat.com> (raw)

These patches let virtio-blk use the new support for toggling the cache
mode between writethrough and writeback.

The first patch introduces a new feature bit and configuration field to
do this.  The second patch disables writeback caching for guests that do
not negotiate VIRTIO_BLK_F_WCACHE (meaning that they cannot send flush
requests), so that limited or older guests are now safe wrt power losses.
VIRTIO_BLK_F_FLUSH has been introduced in Linux 2.6.32 (in 2009) and was
backported to RHEL/CentOS 5.6 (in 2010).

The Windows drivers (which work by emulating SCSI on top of virtio-blk)
have bugs in this area, which I reported on the Red Hat Bugzilla as
bugs 837321 and 837324.  With these patches they will suffer a
performance hit but gain correctness.

Paolo Bonzini (2):
  virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE
  virtio-blk: disable write cache if not negotiated

 hw/virtio-blk.c |   30 ++++++++++++++++++++++++++++--
 hw/virtio-blk.h |    4 +++-
 2 files changed, 31 insertions(+), 3 deletions(-)

-- 
1.7.10.2

             reply	other threads:[~2012-07-03 13:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 13:20 Paolo Bonzini [this message]
2012-07-03 13:20 ` [Qemu-devel] [PATCH 1/2] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE Paolo Bonzini
2012-07-03 13:46   ` Kevin Wolf
2012-07-03 13:54     ` Paolo Bonzini
2012-07-03 13:20 ` [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated Paolo Bonzini
2012-07-03 13:49   ` Kevin Wolf
2012-07-03 13:51     ` Paolo Bonzini
2012-07-04 10:16       ` Kevin Wolf
2012-07-04 12:21         ` Paolo Bonzini
2012-07-04 12:50           ` Kevin Wolf
2012-07-04 13:20             ` Paolo Bonzini
2012-07-23 16:32 ` [Qemu-devel] [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements Paolo Bonzini
2012-08-01 15:52   ` Paolo Bonzini
2012-08-01 16:25     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341321642-24598-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).