From: Peter Maydell <peter.maydell@linaro.org>
To: Anthony Liguori <anthony@codemonkey.ws>,
Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>
Subject: [Qemu-devel] [PATCH 03/10] hw/exynos4210.c: Fix misleading initialization of IROM mirror
Date: Wed, 4 Jul 2012 12:14:07 +0100 [thread overview]
Message-ID: <1341400454-20145-4-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1341400454-20145-1-git-send-email-peter.maydell@linaro.org>
From: Evgeny Voevodin <e.voevodin@samsung.com>
We want to mirror whole IROM and should pass zero instead of
EXYNOS4210_IROM_BASE_ADDR (though it equals to zero too) since
memory_region_init_alias takes an offset within an original
region as an argument.
Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/exynos4210.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/exynos4210.c b/hw/exynos4210.c
index 9c20b3f..80a00b9 100644
--- a/hw/exynos4210.c
+++ b/hw/exynos4210.c
@@ -216,7 +216,7 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem,
/* mirror of iROM */
memory_region_init_alias(&s->irom_alias_mem, "exynos4210.irom_alias",
&s->irom_mem,
- EXYNOS4210_IROM_BASE_ADDR,
+ 0,
EXYNOS4210_IROM_SIZE);
memory_region_set_readonly(&s->irom_alias_mem, true);
memory_region_add_subregion(system_mem, EXYNOS4210_IROM_MIRROR_BASE_ADDR,
--
1.7.1
next prev parent reply other threads:[~2012-07-04 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 11:14 [Qemu-devel] [PULL 00/10] arm-devs queue Peter Maydell
2012-07-04 11:14 ` [Qemu-devel] [PATCH 01/10] ARM: hw/exynos4210_mct.c: Fix a bug which hangs Linux kernel Peter Maydell
2012-07-04 11:14 ` [Qemu-devel] [PATCH 02/10] hw/exynos4210_pwm.c: Fix STOP status in tick handler Peter Maydell
2012-07-04 11:14 ` Peter Maydell [this message]
2012-07-04 11:14 ` [Qemu-devel] [PATCH 04/10] Exynos4: add RTC device Peter Maydell
2012-07-04 11:14 ` [Qemu-devel] [PATCH 05/10] i.MX: UART support Peter Maydell
2012-07-04 11:14 ` [Qemu-devel] [PATCH 06/10] i.MX31: Clock Control Module Peter Maydell
2012-07-04 11:14 ` [Qemu-devel] [PATCH 07/10] i.MX31: Timers Peter Maydell
2012-07-04 11:14 ` [Qemu-devel] [PATCH 08/10] i.MX31: Interrupt Controller Peter Maydell
2012-07-04 11:14 ` [Qemu-devel] [PATCH 09/10] i.MX31: KZM-ARM11-01 evaluation board Peter Maydell
2012-07-04 11:14 ` [Qemu-devel] [PATCH 10/10] hw/cadence_gem: Make rx_desc_addr and tx_desc_addr uint32_t Peter Maydell
2012-07-07 9:21 ` [Qemu-devel] [PULL 00/10] arm-devs queue Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341400454-20145-4-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).