From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmNXX-0001Uw-EF for qemu-devel@nongnu.org; Wed, 04 Jul 2012 07:14:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmNXP-0005RC-O6 for qemu-devel@nongnu.org; Wed, 04 Jul 2012 07:14:35 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:41862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmNXP-0005PW-HD for qemu-devel@nongnu.org; Wed, 04 Jul 2012 07:14:27 -0400 From: Peter Maydell Date: Wed, 4 Jul 2012 12:14:07 +0100 Message-Id: <1341400454-20145-4-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1341400454-20145-1-git-send-email-peter.maydell@linaro.org> References: <1341400454-20145-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 03/10] hw/exynos4210.c: Fix misleading initialization of IROM mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , Blue Swirl Cc: qemu-devel@nongnu.org, Paul Brook From: Evgeny Voevodin We want to mirror whole IROM and should pass zero instead of EXYNOS4210_IROM_BASE_ADDR (though it equals to zero too) since memory_region_init_alias takes an offset within an original region as an argument. Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/exynos4210.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210.c b/hw/exynos4210.c index 9c20b3f..80a00b9 100644 --- a/hw/exynos4210.c +++ b/hw/exynos4210.c @@ -216,7 +216,7 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem, /* mirror of iROM */ memory_region_init_alias(&s->irom_alias_mem, "exynos4210.irom_alias", &s->irom_mem, - EXYNOS4210_IROM_BASE_ADDR, + 0, EXYNOS4210_IROM_SIZE); memory_region_set_readonly(&s->irom_alias_mem, true); memory_region_add_subregion(system_mem, EXYNOS4210_IROM_MIRROR_BASE_ADDR, -- 1.7.1