qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <sw@weilnetz.de>,
	patches@linaro.org
Subject: [Qemu-devel] [PATCH 1/3] target-i386: Remove unused macros
Date: Thu,  5 Jul 2012 22:28:58 +0100	[thread overview]
Message-ID: <1341523740-22711-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1341523740-22711-1-git-send-email-peter.maydell@linaro.org>

Commit 11f8cdb removed all the uses of the X86_64_ONLY
macro. The BUGGY_64() macro has been unused for a long time:
it originally marked some ops which couldn't be enabled
because of issues with the pre-TCG code generation scheme.
Remove the now-unnecessary definitions of both macros.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-i386/translate.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/target-i386/translate.c b/target-i386/translate.c
index a00a6a1..8d696ea 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -38,17 +38,11 @@
 #define PREFIX_ADR    0x10
 
 #ifdef TARGET_X86_64
-#define X86_64_ONLY(x) x
 #define X86_64_DEF(...)  __VA_ARGS__
 #define CODE64(s) ((s)->code64)
 #define REX_X(s) ((s)->rex_x)
 #define REX_B(s) ((s)->rex_b)
-/* XXX: gcc generates push/pop in some opcodes, so we cannot use them */
-#if 1
-#define BUGGY_64(x) NULL
-#endif
 #else
-#define X86_64_ONLY(x) NULL
 #define X86_64_DEF(...)
 #define CODE64(s) 0
 #define REX_X(s) 0
-- 
1.7.5.4

  reply	other threads:[~2012-07-05 21:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 21:28 [Qemu-devel] [PATCH 0/3] target-i386: minor code cleanups Peter Maydell
2012-07-05 21:28 ` Peter Maydell [this message]
2012-07-06  5:31   ` [Qemu-devel] [PATCH 1/3] target-i386: Remove unused macros Stefan Weil
2012-07-05 21:28 ` [Qemu-devel] [PATCH 2/3] target-i386: Remove confusing X86_64_DEF macro Peter Maydell
2012-07-05 21:29 ` [Qemu-devel] [PATCH 3/3] target-i386: make it clearer that op table accesses don't overrun Peter Maydell
2012-07-06  5:49   ` Stefan Weil
2012-07-07  9:22 ` [Qemu-devel] [PATCH 0/3] target-i386: minor code cleanups Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341523740-22711-2-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=blauwirbel@gmail.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).