From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn5TL-0003Xc-7l for qemu-devel@nongnu.org; Fri, 06 Jul 2012 06:09:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn5TC-0001PP-Mv for qemu-devel@nongnu.org; Fri, 06 Jul 2012 06:09:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn5TC-0001Oj-FD for qemu-devel@nongnu.org; Fri, 06 Jul 2012 06:09:02 -0400 From: Hans de Goede Date: Fri, 6 Jul 2012 12:09:33 +0200 Message-Id: <1341569373-9478-3-git-send-email-hdegoede@redhat.com> In-Reply-To: <1341569373-9478-1-git-send-email-hdegoede@redhat.com> References: <1341569373-9478-1-git-send-email-hdegoede@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] usb-ehci: Fix an assert whenever isoc transfers are used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Hans de Goede , qemu-devel@nongnu.org, kvm@vger.kernel.org hcd-ehci.c is missing an usb_packet_init() call for the ipacket UsbPacket it uses for isoc transfers, triggering an assert (taking the entire vm down) in usb_packet_setup as soon as any isoc transfers are done by a high speed USB device. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index e759c99..eaa3ddd 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2300,6 +2300,7 @@ static int usb_ehci_initfn(PCIDevice *dev) s->frame_timer = qemu_new_timer_ns(vm_clock, ehci_frame_timer, s); QTAILQ_INIT(&s->aqueues); QTAILQ_INIT(&s->pqueues); + usb_packet_init(&s->ipacket); qemu_register_reset(ehci_reset, s); -- 1.7.10.4